r23203 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r23202‎ | r23203 | r23204 >
Date:09:07, 22 June 2007
Author:david
Status:old
Tags:
Comment:
Merged revisions 23120-23202 via svnmerge from
svn+ssh://david@svn.wikimedia.org/svnroot/mediawiki/trunk/phase3

........
r23128 | raymond | 2007-06-20 09:06:01 -0700 (Wed, 20 Jun 2007) | 2 lines

* (bug 10296) Update Albanian language
based on [[sq:special:allmessages]]
........
r23129 | raymond | 2007-06-20 09:50:28 -0700 (Wed, 20 Jun 2007) | 3 lines

* Housekeeping:
Make messages 'isbn' and 'booksources-isbn' optional as ISBN is untranslated in all latin and most non-latin script languages.
Removing theses messages from message files.
........
r23130 | aaron | 2007-06-20 11:41:15 -0700 (Wed, 20 Jun 2007) | 1 line

*Goddamn hack, modify error level temporarily while some dates are parsed so as not to make E_STRICT unusable due to local time complaint floodage
........
r23131 | aaron | 2007-06-20 11:49:54 -0700 (Wed, 20 Jun 2007) | 1 line

*error_reporting() again...sigh
........
r23133 | brion | 2007-06-20 12:35:17 -0700 (Wed, 20 Jun 2007) | 5 lines

* Throw a showstopper exception when a hook function fails to return a value.
Forgetting to give a 'true' return value is a very common error which tends
to cause hard-to-track-down interactions between extensions.
........
r23135 | aaron | 2007-06-20 13:33:44 -0700 (Wed, 20 Jun 2007) | 1 line

*More system date bitching
........
r23145 | aaron | 2007-06-20 15:25:39 -0700 (Wed, 20 Jun 2007) | 1 line

*Use wfSuppressWarnings() instead of error_reporting()
........
r23151 | nickj | 2007-06-20 21:28:06 -0700 (Wed, 20 Jun 2007) | 4 lines

Prevent error on viewing [[Special:Allmessages]] when LocalSettings.php includes
a custom file that extends the ApiQueryGeneratorBase abstract base class, by adding
ApiQueryGeneratorBase to the list of classes that the autoloader knows how to handle.
........
r23155 | robchurch | 2007-06-21 04:41:24 -0700 (Thu, 21 Jun 2007) | 1 line

(bug 10325) Fix regression in form action on Special:Listusers
........
r23157 | robchurch | 2007-06-21 04:50:15 -0700 (Thu, 21 Jun 2007) | 1 line

Minor code refactoring
........
r23159 | jeluf | 2007-06-21 05:05:30 -0700 (Thu, 21 Jun 2007) | 1 line

Language stub for the Wolof language, setting fallback to French
........
r23162 | aaron | 2007-06-21 07:12:50 -0700 (Thu, 21 Jun 2007) | 1 line

*Add $wgCustomJobs for adding functions/subclasses to jobqueue
........
r23163 | robchurch | 2007-06-21 07:21:44 -0700 (Thu, 21 Jun 2007) | 1 line

Remove errant return, breaks switch statement for 'htmlCacheUpdate' jobs
........
r23165 | aaron | 2007-06-21 08:29:05 -0700 (Thu, 21 Jun 2007) | 1 line

*Add wfQueriesMustScale(), a quick dirt way to see whether we can get away with inefficient queries or if the job queue is best. Will likely need tweaking.
........
r23166 | raymond | 2007-06-21 08:51:28 -0700 (Thu, 21 Jun 2007) | 3 lines

* (bug 9415) Added options to Special:Protect to allow setting of per-page robot
policies. This can be done only by users with the 'editrobots' permission
Based on a patch of AmiDaniel
........
r23167 | rotem | 2007-06-21 09:04:42 -0700 (Thu, 21 Jun 2007) | 1 line

Update and fix.
........
r23168 | rotem | 2007-06-21 09:08:11 -0700 (Thu, 21 Jun 2007) | 1 line

Adding a direction mark, for RTL wikis (it may be better to localise the text, though).
........
r23173 | robchurch | 2007-06-21 12:11:24 -0700 (Thu, 21 Jun 2007) | 6 lines

Some job cleanup:

* Move Jobs left in JobQueue.php to their own file
* Ditch $wgCustomJobs in favour of $wgJobClasses, which acts as a dictionary and allows extensions to add custom jobs
* Standardise Job derivative constructors and update everywhere
* Make sure all overriding implementations of Job::run() return true to avoid bogus "Error" report in runJobs.php
........
r23174 | raymond | 2007-06-21 12:13:08 -0700 (Thu, 21 Jun 2007) | 2 lines

* (bug 10327) Update Swedish translations
Patch by Lejonel
........
r23175 | raymond | 2007-06-21 12:21:10 -0700 (Thu, 21 Jun 2007) | 1 line

eol-style:native
........
r23176 | wegge | 2007-06-21 13:33:17 -0700 (Thu, 21 Jun 2007) | 1 line

Updated translations for da
........
r23177 | tstarling | 2007-06-21 13:44:47 -0700 (Thu, 21 Jun 2007) | 1 line

Pass through wpIgnoreWarning request parameter to the form.
........
r23178 | robchurch | 2007-06-21 13:50:29 -0700 (Thu, 21 Jun 2007) | 2 lines

* Allow wiki links in "protect-robotspolicy", I imagine people are likely to want to link to help
* Typos
........
r23179 | robchurch | 2007-06-21 13:58:48 -0700 (Thu, 21 Jun 2007) | 1 line

i18n and better label text, don't assume all users speak robots.txt
........
r23181 | robchurch | 2007-06-21 14:18:29 -0700 (Thu, 21 Jun 2007) | 1 line

Bug fix
........
r23182 | raymond | 2007-06-21 15:02:52 -0700 (Thu, 21 Jun 2007) | 2 lines

* Housekeeping:
Removing more untranslated, optional stuff from message files
........
r23189 | aaron | 2007-06-21 17:21:54 -0700 (Thu, 21 Jun 2007) | 1 line

*Clean up comment
........
r23191 | aaron | 2007-06-21 19:08:22 -0700 (Thu, 21 Jun 2007) | 1 line

*Increase RC prune change to 1/100
........
r23196 | rotem | 2007-06-21 23:19:15 -0700 (Thu, 21 Jun 2007) | 1 line

Update and clarification.
........
r23197 | amidaniel | 2007-06-21 23:23:02 -0700 (Thu, 21 Jun 2007) | 1 line

Special:Randompage with no parameters now selects a random page from any namespace in $wgContentNamespaces, rather than just from NS_MAIN.
........
r23198 | ivanlanin | 2007-06-22 00:37:02 -0700 (Fri, 22 Jun 2007) | 1 line

Indonesian (id) localisation updates.
........
r23199 | raymond | 2007-06-22 00:41:45 -0700 (Fri, 22 Jun 2007) | 3 lines

* Some cosmetic tweaks
** ProtectionForm: move 'watch this page' checkbox between reason field and submit button like in all other forms too
** SpecialMovepage.php: right shift checkboxes a bit like in all other forms too, move hardcoded colons to message file for better localization
........
r23200 | rotem | 2007-06-22 00:49:45 -0700 (Fri, 22 Jun 2007) | 1 line

Update.
........
r23201 | raymond | 2007-06-22 01:40:20 -0700 (Fri, 22 Jun 2007) | 2 lines

* (bug 7859) Update Kazakh translations
Patch by AlefZet
........
Modified paths:
  • /branches/liquidthreads (modified) (history)
  • /branches/liquidthreads/RELEASE-NOTES (modified) (history)
  • /branches/liquidthreads/includes/Article.php (modified) (history)
  • /branches/liquidthreads/includes/AutoLoader.php (modified) (history)
  • /branches/liquidthreads/includes/DefaultSettings.php (modified) (history)
  • /branches/liquidthreads/includes/EmaillingJob.php (added) (history)
  • /branches/liquidthreads/includes/EmaillingJob.php (added) (history)
  • /branches/liquidthreads/includes/EnotifNotifyJob.php (added) (history)
  • /branches/liquidthreads/includes/EnotifNotifyJob.php (added) (history)
  • /branches/liquidthreads/includes/GlobalFunctions.php (modified) (history)
  • /branches/liquidthreads/includes/HTMLCacheUpdate.php (modified) (history)
  • /branches/liquidthreads/includes/Hooks.php (modified) (history)
  • /branches/liquidthreads/includes/JobQueue.php (modified) (history)
  • /branches/liquidthreads/includes/LinksUpdate.php (modified) (history)
  • /branches/liquidthreads/includes/OutputPage.php (modified) (history)
  • /branches/liquidthreads/includes/Parser.php (modified) (history)
  • /branches/liquidthreads/includes/ProtectionForm.php (modified) (history)
  • /branches/liquidthreads/includes/RefreshLinksJob.php (added) (history)
  • /branches/liquidthreads/includes/RefreshLinksJob.php (added) (history)
  • /branches/liquidthreads/includes/SpecialListusers.php (modified) (history)
  • /branches/liquidthreads/includes/SpecialMovepage.php (modified) (history)
  • /branches/liquidthreads/includes/SpecialRandompage.php (modified) (history)
  • /branches/liquidthreads/includes/SpecialUpload.php (modified) (history)
  • /branches/liquidthreads/includes/Title.php (modified) (history)
  • /branches/liquidthreads/includes/UserMailer.php (modified) (history)
  • /branches/liquidthreads/includes/filerepo/File.php (modified) (history)
  • /branches/liquidthreads/languages/Language.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesBg.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesCa.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesCs.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesCv.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesDa.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesDe.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesEl.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesEn.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesEs.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesEu.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesFi.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesFiu_vro.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesFr.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesFur.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesGa.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesHak.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesHe.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesHsb.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesHy.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesId.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesIt.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesJa.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesKa.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesKk_cn.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesKk_kz.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesKk_tr.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesKo.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesKsh.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesLn.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesLt.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesMs.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesNds.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesNn.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesNo.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesOc.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesPl.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesPms.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesPt.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesRo.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesRu.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesSk.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesSl.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesSq.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesSr_ec.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesSr_el.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesSu.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesSv.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesTt.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesUk.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesUz.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesWa.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesWo.php (added) (history)
  • /branches/liquidthreads/languages/messages/MessagesWo.php (added) (history)
  • /branches/liquidthreads/languages/messages/MessagesZh_classical.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesZh_cn.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesZh_tw.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesZh_yue.php (modified) (history)
  • /branches/liquidthreads/maintenance/language/messageTypes.inc (modified) (history)
  • /branches/liquidthreads/maintenance/language/messages.inc (modified) (history)

Follow-up revisions

RevisionCommit summaryAuthorDate
r23286(bug 7859) Kazakh message updates [patch from AlefZet]robchurch09:27, 23 June 2007
r23407Merged revisions 23203-23405 via svnmerge from...david23:00, 25 June 2007

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r17525(bug 7859) Updates for Kazakh i18nrotem13:30, 10 November 2006
r17537(bug 7859) Updates for Kazakh i18nrotem16:57, 11 November 2006
r17723(bug 7859) Updates for Kazakh i18nrotem13:46, 16 November 2006
r17781(bug 7859) Updates for Kazakh i18nrotem13:03, 18 November 2006
r17908(bug 7859) Updates for Kazakh i18nrotem15:06, 24 November 2006
r17924(bug 7859) Updates for Kazakh i18nrotem14:12, 25 November 2006
r17925(bug 7859) Updates for Kazakh i18nrotem14:35, 25 November 2006
r19547* (bug 7859) yet another kazakh localisation patch.leon09:55, 21 January 2007
r20180* (bug 7859) Update Kazakh messages...raymond18:32, 6 March 2007
r20737* (bug 7859) Update Kazahk translations...raymond12:10, 27 March 2007
r20948* (bug 7859) Update Kazahk translations...raymond18:13, 2 April 2007
r21604* (bug 7859) Update Kazakh translations...raymond04:54, 26 April 2007
r21680* (bug 7859) Update Kazakh translations...raymond05:05, 28 April 2007
r21706* (bug 7859) Update Kazakh translations...raymond20:57, 29 April 2007
r21746* (bug 7859) Update Kazakh translations...raymond09:40, 1 May 2007
r21747* (bug 7859) Update Kazakh translations...raymond09:45, 1 May 2007
r22009* (bug 7859) Update Kazakh translations...raymond20:57, 8 May 2007
r22056* (bug 7859) Update Kazakh translations...raymond21:13, 9 May 2007
r22062* (bug 7859) Update Kazakh translations...raymond10:32, 10 May 2007
r22081* (bug 7859) Update Kazakh translations...raymond19:53, 10 May 2007
r22082* (bug 7859) Update Kazakh translations...raymond20:01, 10 May 2007
r22201* (bug 7859) Update Kazakh translations...raymond10:53, 16 May 2007
r22269* (bug 7859) Update Kazakh translations...raymond20:28, 19 May 2007
r22510* (bug 7859) Update Kazakh translations...raymond16:37, 28 May 2007
r22518Merged revisions 22484-22517 via svnmerge from...david22:22, 28 May 2007
r22536* Adding 1 message to optional per hint (bug 7859, comment# 71)...raymond14:43, 29 May 2007
r22549Merged revisions 22518-22547 via svnmerge from...david01:48, 30 May 2007
r22557* (bug 7859) Update Kazakh translations...raymond09:47, 30 May 2007
r22587Merged revisions 22555-22586 via svnmerge from...david03:19, 31 May 2007
r22794* (bug 7859) Update Kazakh translations...raymond10:01, 6 June 2007
r22811Merged revisions 22791-22810 via svnmerge from...david07:26, 7 June 2007
r22901* (bug 7859) Update Kazakh translations...raymond08:53, 11 June 2007
r22919Merged revisions 22878-22918 via svnmerge from...david00:00, 12 June 2007
r22973* (bug 7859) Update Kazakh translations...raymond22:27, 13 June 2007
r23039Merged revisions 22967-23037 via svnmerge from...david20:15, 16 June 2007
r23058* (bug 7859) Update Kazakh translations...raymond07:49, 18 June 2007
r23087Merged revisions 23050-23086 via svnmerge from...david03:14, 19 June 2007
r23128* (bug 10296) Update Albanian language...raymond16:06, 20 June 2007
r23129* Housekeeping:...raymond16:50, 20 June 2007
r23130*Goddamn hack, modify error level temporarily while some dates are parsed so ...aaron18:41, 20 June 2007
r23131*error_reporting() again...sighaaron18:49, 20 June 2007
r23133* Throw a showstopper exception when a hook function fails to return a value....brion19:35, 20 June 2007
r23135*More system date bitchingaaron20:33, 20 June 2007
r23145*Use wfSuppressWarnings() instead of error_reporting()aaron22:25, 20 June 2007
r23151Prevent error on viewing [[Special:Allmessages]] when LocalSettings.php includes...nickj04:28, 21 June 2007
r23155(bug 10325) Fix regression in form action on Special:Listusersrobchurch11:41, 21 June 2007
r23157Minor code refactoringrobchurch11:50, 21 June 2007
r23159Language stub for the Wolof language, setting fallback to Frenchjeluf12:05, 21 June 2007
r23162*Add $wgCustomJobs for adding functions/subclasses to jobqueueaaron14:12, 21 June 2007
r23163Remove errant return, breaks switch statement for 'htmlCacheUpdate' jobsrobchurch14:21, 21 June 2007
r23165*Add wfQueriesMustScale(), a quick dirt way to see whether we can get away wi...aaron15:29, 21 June 2007
r23166* (bug 9415) Added options to Special:Protect to allow setting of per-page robot...raymond15:51, 21 June 2007
r23167Update and fix.rotem16:04, 21 June 2007
r23168Adding a direction mark, for RTL wikis (it may be better to localise the text...rotem16:08, 21 June 2007
r23173Some job cleanup:...robchurch19:11, 21 June 2007
r23174* (bug 10327) Update Swedish translations...raymond19:13, 21 June 2007
r23175eol-style:nativeraymond19:21, 21 June 2007
r23176Updated translations for dawegge20:33, 21 June 2007
r23177Pass through wpIgnoreWarning request parameter to the form.tstarling20:44, 21 June 2007
r23178* Allow wiki links in "protect-robotspolicy", I imagine people are likely to ...robchurch20:50, 21 June 2007
r23179i18n and better label text, don't assume all users speak robots.txtrobchurch20:58, 21 June 2007
r23181Bug fixrobchurch21:18, 21 June 2007
r23182* Housekeeping:...raymond22:02, 21 June 2007
r23189*Clean up commentaaron00:21, 22 June 2007
r23191*Increase RC prune change to 1/100aaron02:08, 22 June 2007
r23196Update and clarification.rotem06:19, 22 June 2007
r23197Special:Randompage with no parameters now selects a random page from any name...amidaniel06:23, 22 June 2007
r23198Indonesian (id) localisation updates.ivanlanin07:37, 22 June 2007
r23199* Some cosmetic tweaks...raymond07:41, 22 June 2007
r23200Update.rotem07:49, 22 June 2007
r23201* (bug 7859) Update Kazakh translations...raymond08:40, 22 June 2007

Status & tagging log