r23199 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r23198‎ | r23199 | r23200 >
Date:07:41, 22 June 2007
Author:raymond
Status:old
Tags:
Comment:
* Some cosmetic tweaks
** ProtectionForm: move 'watch this page' checkbox between reason field and submit button like in all other forms too
** SpecialMovepage.php: right shift checkboxes a bit like in all other forms too, move hardcoded colons to message file for better localization
Modified paths:
  • /trunk/phase3/includes/ProtectionForm.php (modified) (history)
  • /trunk/phase3/includes/SpecialMovepage.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesDe.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/ProtectionForm.php
@@ -258,14 +258,12 @@
259259 if( $wgEnableCascadingProtection )
260260 $out .= '<tr><td></td><td>' . $this->buildCascadeInput() . "</td></tr>\n";
261261
262 - if( !$this->disabled )
263 - $out .= '<tr><td></td><td>' . $this->buildWatchInput() . "</td></tr>\n";
264 -
265262 $out .= $this->buildRobotsInput();
266263 $out .= $this->buildExpiryInput();
267264
268265 if( !$this->disabled ) {
269266 $out .= "<tr><td>" . $this->buildReasonInput() . "</td></tr>\n";
 267+ $out .= "<tr><td></td><td>" . $this->buildWatchInput() . "</td></tr>\n";
270268 $out .= "<tr><td></td><td>" . $this->buildSubmit() . "</td></tr>\n";
271269 }
272270
Index: trunk/phase3/includes/SpecialMovepage.php
@@ -105,14 +105,10 @@
106106 if ( $err == 'articleexists' && $wgUser->isAllowed( 'delete' ) ) {
107107 $wgOut->addWikiText( wfMsg( 'delete_and_move_text', $encNewTitle ) );
108108 $movepagebtn = wfMsgHtml( 'delete_and_move' );
109 - $confirmText = wfMsgHtml( 'delete_and_move_confirm' );
110109 $submitVar = 'wpDeleteAndMove';
111110 $confirm = "
112111 <tr>
113 - <td align='$end'>
114 - <input type='checkbox' name='wpConfirm' id='wpConfirm' value=\"true\" />
115 - </td>
116 - <td align='$start'><label for='wpConfirm'>{$confirmText}</label></td>
 112+ <td></td><td>" . Xml::checkLabel( wfMsg( 'delete_and_move_confirm' ), 'wpConfirm', 'wpConfirm' ) . "</td>
117113 </tr>";
118114 $err = '';
119115 } else {
@@ -131,7 +127,6 @@
132128
133129 $movearticle = wfMsgHtml( 'movearticle' );
134130 $newtitle = wfMsgHtml( 'newtitle' );
135 - $movetalk = wfMsgHtml( 'movetalk' );
136131 $movereason = wfMsgHtml( 'movereason' );
137132
138133 $titleObj = SpecialPage::getTitleFor( 'Movepage' );
@@ -149,18 +144,18 @@
150145 <form id=\"movepage\" method=\"post\" action=\"{$action}\">
151146 <table border='0'>
152147 <tr>
153 - <td align='$end'>{$movearticle}:</td>
 148+ <td align='$end'>{$movearticle}</td>
154149 <td align='$start'><strong>{$oldTitle}</strong></td>
155150 </tr>
156151 <tr>
157 - <td align='$end'><label for='wpNewTitle'>{$newtitle}:</label></td>
 152+ <td align='$end'><label for='wpNewTitle'>{$newtitle}</label></td>
158153 <td align='$start'>
159154 <input type='text' size='40' name='wpNewTitle' id='wpNewTitle' value=\"{$encNewTitle}\" />
160155 <input type='hidden' name=\"wpOldTitle\" value=\"{$encOldTitle}\" />
161156 </td>
162157 </tr>
163158 <tr>
164 - <td align='$end' valign='top'><br /><label for='wpReason'>{$movereason}:</label></td>
 159+ <td align='$end' valign='top'><br /><label for='wpReason'>{$movereason}</label></td>
165160 <td align='$start' valign='top'><br />
166161 <textarea cols='60' rows='2' name='wpReason' id='wpReason'>{$encReason}</textarea>
167162 </td>
@@ -169,20 +164,16 @@
170165 if ( $considerTalk ) {
171166 $wgOut->addHTML( "
172167 <tr>
173 - <td align='$end'>
174 - <input type='checkbox' id=\"wpMovetalk\" name=\"wpMovetalk\"{$moveTalkChecked} value=\"1\" />
175 - </td>
176 - <td><label for=\"wpMovetalk\">{$movetalk}</label></td>
 168+ <td></td><td>" . Xml::checkLabel( wfMsg( 'movetalk' ), 'wpMovetalk', 'wpMovetalk', $moveTalkChecked ) . "</td>
177169 </tr>" );
178170 }
179 -
 171+
180172 $watchChecked = $this->watch || $wgUser->getBoolOption( 'watchmoves' ) || $ot->userIsWatching();
181173 $watch = '<tr>';
182 - $watch .= "<td align=\"$end\">" . Xml::check( 'wpWatch', $watchChecked, array( 'id' => 'watch' ) ) . '</td>';
183 - $watch .= '<td>' . Xml::label( wfMsg( 'move-watch' ), 'watch' ) . '</td>';
 174+ $watch .= '<td></td><td>' . Xml::checkLabel( wfMsg( 'move-watch' ), 'wpWatch', 'watch', $watchChecked ) . '</td>';
184175 $watch .= '</tr>';
185176 $wgOut->addHtml( $watch );
186 -
 177+
187178 $wgOut->addHTML( "
188179 {$confirm}
189180 <tr>
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -2085,11 +2085,11 @@
20862086 *You uncheck the box below.
20872087
20882088 In those cases, you will have to move or merge the page manually if desired.",
2089 -'movearticle' => 'Move page',
 2089+'movearticle' => 'Move page:',
20902090 'movenologin' => 'Not logged in',
20912091 'movenologintext' => 'You must be a registered user and [[Special:Userlogin|logged in]]
20922092 to move a page.',
2093 -'newtitle' => 'To new title',
 2093+'newtitle' => 'To new title:',
20942094 'move-watch' => 'Watch this page',
20952095 'movepagebtn' => 'Move page',
20962096 'pagemovedsub' => 'Move succeeded',
@@ -2106,7 +2106,7 @@
21072107 '1movedto2_redir' => '[[$1]] moved to [[$2]] over redirect',
21082108 'movelogpage' => 'Move log',
21092109 'movelogpagetext' => 'Below is a list of page moved.',
2110 -'movereason' => 'Reason',
 2110+'movereason' => 'Reason:',
21112111 'revertmove' => 'revert',
21122112 'delete_and_move' => 'Delete and move',
21132113 'delete_and_move_text' => '==Deletion required==
Index: trunk/phase3/languages/messages/MessagesDe.php
@@ -1441,6 +1441,8 @@
14421442 'protect-expiring' => 'bis $1 (UTC)',
14431443 'protect-cascade' => 'Kaskadierende Sperre – alle in diese Seite eingebundenen Vorlagen werden ebenfalls gesperrt.',
14441444 'protect-robotspolicy' => 'Anweisung für Suchroboter:',
 1445+'protect-robots-noindex' => 'nicht indizieren (noindex)',
 1446+'protect-robots-nofollow' => 'Links nicht folgen (nofollow)',
14451447 'restriction-type' => 'Schutzstatus',
14461448 'restriction-level' => 'Schutzhöhe',
14471449 'minimum-size' => 'Mindestgröße:',
@@ -1644,12 +1646,10 @@
16451647 *Sie wählen die untenstehende Option ab.
16461648
16471649 In diesen Fällen müssen Sie, falls gewünscht, den Inhalt der Seite von Hand verschieben oder zusammenführen.",
1648 -'movearticle' => 'Seite verschieben',
 1650+'movearticle' => 'Seite verschieben:',
16491651 'movenologin' => 'Sie sind nicht angemeldet',
1650 -'movenologintext' => 'Sie müssen ein registrierter Benutzer und
1651 -[[Special:Userlogin|angemeldet]] sein,
1652 -um eine Seite zu verschieben.',
1653 -'newtitle' => 'Ziel',
 1652+'movenologintext' => 'Sie müssen ein registrierter Benutzer und [[Special:Userlogin|angemeldet]] sein, um eine Seite zu verschieben.',
 1653+'newtitle' => 'Ziel:',
16541654 'move-watch' => 'Diese Seite beobachten',
16551655 'movepagebtn' => 'Seite verschieben',
16561656 'pagemovedsub' => 'Verschiebung erfolgreich',
@@ -1665,7 +1665,7 @@
16661666 '1movedto2_redir' => 'hat „[[$1]]“ nach „[[$2]]“ verschoben und dabei eine Weiterleitung überschrieben',
16671667 'movelogpage' => 'Verschiebungs-Logbuch',
16681668 'movelogpagetext' => 'Dies ist eine Liste aller verschobenen Seiten.',
1669 -'movereason' => 'Begründung',
 1669+'movereason' => 'Begründung:',
16701670 'revertmove' => 'zurück verschieben',
16711671 'delete_and_move' => 'Löschen und Verschieben',
16721672 'delete_and_move_text' => '==Zielseite vorhanden, löschen?==

Follow-up revisions

RevisionCommit summaryAuthorDate
r23203Merged revisions 23120-23202 via svnmerge from...david09:07, 22 June 2007

Status & tagging log