r23179 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r23178‎ | r23179 | r23180 >
Date:20:58, 21 June 2007
Author:robchurch
Status:old
Tags:
Comment:
i18n and better label text, don't assume all users speak robots.txt
Modified paths:
  • /trunk/phase3/includes/ProtectionForm.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)
  • /trunk/phase3/maintenance/language/messages.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/language/messages.inc
@@ -1183,6 +1183,8 @@
11841184 'protect-expiring',
11851185 'protect-cascade',
11861186 'protect-robotspolicy',
 1187+ 'protect-robots-noindex',
 1188+ 'protect-robots-nofollow',
11871189 'restriction-type',
11881190 'restriction-level',
11891191 'minimum-size',
Index: trunk/phase3/includes/ProtectionForm.php
@@ -338,9 +338,9 @@
339339 $ret = "<tr><td align=\"right\">";
340340 $ret .= '<label>' . wfMsgExt( 'protect-robotspolicy', array( 'parseinline' ) ) . '</label>';
341341 $ret .= "</td><td align=\"left\" width=\"60\">";
342 - $ret .= Xml::checkLabel( 'noindex', 'mwProtect-robots-noindex', 'mwProtect-robots-noindex', $noindexset, $robotsallowed );
 342+ $ret .= Xml::checkLabel( wfMsgHtml( 'protect-robots-noindex' ), 'mwProtect-robots-noindex', 'mwProtect-robots-noindex', $noindexset, $robotsallowed );
343343 $ret .= $wgContLang->getDirMark();
344 - $ret .= Xml::checkLabel( 'nofollow', 'mwProtect-robots-nofollow', 'mwProtect-robots-nofollow', $nofollowset, $robotsallowed );
 344+ $ret .= Xml::checkLabel( wfMsgHtml( 'protect-robots-nofollow' ), 'mwProtect-robots-nofollow', 'mwProtect-robots-nofollow', $nofollowset, $robotsallowed );
345345 $ret .= "</td></tr>";
346346 return $ret;
347347 }
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -1840,6 +1840,8 @@
18411841 'protect-expiring' => 'expires $1 (UTC)',
18421842 'protect-cascade' => 'Protect pages included in this page (cascading protection)',
18431843 'protect-robotspolicy' => 'Robot policy:',
 1844+'protect-robots-noindex' => 'Do not index',
 1845+'protect-robots-nofollow' => 'Do not follow links',
18441846 'restriction-type' => 'Permission:',
18451847 'restriction-level' => 'Restriction level:',
18461848 'minimum-size' => 'Min size',

Follow-up revisions

RevisionCommit summaryAuthorDate
r23203Merged revisions 23120-23202 via svnmerge from...david09:07, 22 June 2007

Status & tagging log