r23178 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r23177‎ | r23178 | r23179 >
Date:20:50, 21 June 2007
Author:robchurch
Status:old
Tags:
Comment:
* Allow wiki links in "protect-robotspolicy", I imagine people are likely to want to link to help
* Typos
Modified paths:
  • /trunk/phase3/includes/ProtectionForm.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/ProtectionForm.php
@@ -74,11 +74,11 @@
7575 }
7676 }
7777
78 - // Read checkboxex only if user is allowed to change robots policy, otherwise keep previous policy
 78+ // Read checkboxes only if user is allowed to change robots policy, otherwise keep previous policy
7979 if ( $wgUser->isAllowed( 'editrobots' ) ) {
8080 $robotspolicy = $wgRequest->getBool( 'mwProtect-robots-noindex' ) ? 'noindex' : 'index';
8181 $robotspolicy .= $wgRequest->getBool( 'mwProtect-robots-nofollow' ) ? ',nofollow' : ',follow';
82 - // 'index,follow' is default, no need to set this explicitly at this point; is done at Article::View
 82+ // 'index,follow' is default, no need to set this explicitly at this point; is done at Article::view()
8383 $this->mRestrictions['robots'] = ( $robotspolicy == 'index,follow' ) ? '' : $robotspolicy;
8484 }
8585 }
@@ -336,8 +336,8 @@
337337 $noindexset = ( isset( $this->mRestrictions['robots'] ) && strstr( $this->mRestrictions['robots'], 'noindex' ) ) ? true : false;
338338 $nofollowset = ( isset( $this->mRestrictions['robots'] ) && strstr( $this->mRestrictions['robots'], 'nofollow' ) ) ? true : false;
339339 $ret = "<tr><td align=\"right\">";
340 - $ret .= Xml::label( wfMsg( 'protect-robotspolicy' ), 'mwProtect-robots-label' );
341 - $ret .= "</td> <td align=\"left\" width=\"60\">";
 340+ $ret .= '<label>' . wfMsgExt( 'protect-robotspolicy', array( 'parseinline' ) ) . '</label>';
 341+ $ret .= "</td><td align=\"left\" width=\"60\">";
342342 $ret .= Xml::checkLabel( 'noindex', 'mwProtect-robots-noindex', 'mwProtect-robots-noindex', $noindexset, $robotsallowed );
343343 $ret .= $wgContLang->getDirMark();
344344 $ret .= Xml::checkLabel( 'nofollow', 'mwProtect-robots-nofollow', 'mwProtect-robots-nofollow', $nofollowset, $robotsallowed );

Follow-up revisions

RevisionCommit summaryAuthorDate
r23203Merged revisions 23120-23202 via svnmerge from...david09:07, 22 June 2007

Status & tagging log