r22549 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r22548‎ | r22549 | r22550 >
Date:01:48, 30 May 2007
Author:david
Status:old
Tags:
Comment:
Merged revisions 22518-22547 via svnmerge from
svn+ssh://david@svn.wikimedia.org/svnroot/mediawiki/trunk/phase3

........
r22535 | raymond | 2007-05-29 07:11:07 -0700 (Tue, 29 May 2007) | 1 line

(bug 10041, comment #1) typo in language name
........
r22536 | raymond | 2007-05-29 07:43:30 -0700 (Tue, 29 May 2007) | 2 lines

* Adding 1 message to optional per hint (bug 7859, comment# 71)
* Moving 1 message from ignore to optional (some languages like spaces between)
........
r22537 | aaron | 2007-05-29 08:29:10 -0700 (Tue, 29 May 2007) | 1 line

*Fix fucked up grammar in rcnote
........
r22541 | aaron | 2007-05-29 12:53:23 -0700 (Tue, 29 May 2007) | 1 line

*Add U param to parseinline regexp to fix regression that left the \n in parsed messages. (.*) was being greedy swallowing up the \n character before the </p> tag, allowing the \n? to be ignored since it is optional.
........
r22543 | greg | 2007-05-29 13:28:59 -0700 (Tue, 29 May 2007) | 2 lines

The variable mLastResult may be null /or/ false: check for both in affected rows method.
........
r22544 | greg | 2007-05-29 14:04:16 -0700 (Tue, 29 May 2007) | 2 lines

Make sure BlockHideName really defaults to 0, not false. Fixes bug 10007.
........
r22546 | raymond | 2007-05-29 15:02:02 -0700 (Tue, 29 May 2007) | 3 lines

(bug 7960) Link to "what links here" for each "what links here" entry
Patch from Thomas "Tango" Dalton
........
Modified paths:
  • /branches/liquidthreads (modified) (history)
  • /branches/liquidthreads/RELEASE-NOTES (modified) (history)
  • /branches/liquidthreads/includes/DatabasePostgres.php (modified) (history)
  • /branches/liquidthreads/includes/GlobalFunctions.php (modified) (history)
  • /branches/liquidthreads/includes/SpecialBlockip.php (modified) (history)
  • /branches/liquidthreads/includes/SpecialWhatlinkshere.php (modified) (history)
  • /branches/liquidthreads/languages/Names.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesDe.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesEn.php (modified) (history)
  • /branches/liquidthreads/maintenance/language/messageTypes.inc (modified) (history)
  • /branches/liquidthreads/maintenance/language/messages.inc (modified) (history)

Diff [purge]

Index: branches/liquidthreads/maintenance/language/messages.inc
@@ -1265,6 +1265,7 @@
12661266 'istemplate',
12671267 'whatlinkshere-prev',
12681268 'whatlinkshere-next',
 1269+ 'whatlinkshere-links',
12691270 ),
12701271 'block' => array(
12711272 'blockip',
Index: branches/liquidthreads/maintenance/language/messageTypes.inc
@@ -99,7 +99,6 @@
100100 'talkpagetext',
101101 'trackback',
102102 'trackbackexcerpt',
103 - 'widthheight',
104103 );
105104
106105 /** Optional messages, which may be translated only if changed in the other language. */
@@ -164,6 +163,8 @@
165164 'variantname-kk-cn',
166165 'variantname-kk',
167166 'rc-change-size',
 167+ 'resetpass_text',
 168+ 'widthheight',
168169 );
169170
170171 /** EXIF messages, which may be set as optional in several checks, but are generally mandatory */
Index: branches/liquidthreads/includes/GlobalFunctions.php
@@ -592,7 +592,7 @@
593593 } elseif ( in_array('parseinline', $options) ) {
594594 $string = $wgOut->parse( $string, true, true );
595595 $m = array();
596 - if( preg_match( '/^<p>(.*)\n?<\/p>$/s', $string, $m ) ) {
 596+ if( preg_match( '/^<p>(.*)\n?<\/p>$/sU', $string, $m ) ) {
597597 $string = $m[1];
598598 }
599599 } elseif ( in_array('parsemag', $options) ) {
Index: branches/liquidthreads/includes/SpecialWhatlinkshere.php
@@ -230,6 +230,10 @@
231231 $wgOut->addHTML( ' (' . implode( ', ', $props ) . ') ' );
232232 }
233233
 234+ //add whatlinkshere link
 235+ $whatlink=$this->skin->makeKnownLinkObj( SpecialPage::getTitleFor( 'Whatlinkshere', $nt->getPrefixedDBkey() ), wfMsgHtml( 'whatlinkshere-links' ) );
 236+ $wgOut->addHTML(' ' . $whatlink);
 237+
234238 if ( $row->page_is_redirect ) {
235239 if ( $level < 2 ) {
236240 $this->showIndirectLinks( $level + 1, $nt, 500 );
Index: branches/liquidthreads/includes/SpecialBlockip.php
@@ -61,7 +61,7 @@
6262 $this->BlockCreateAccount = $wgRequest->getBool( 'wpCreateAccount', $byDefault );
6363 $this->BlockEnableAutoblock = $wgRequest->getBool( 'wpEnableAutoblock', $byDefault );
6464 # Re-check user's rights to hide names, very serious, defaults to 0
65 - $this->BlockHideName = $wgRequest->getBool( 'wpHideName', 0 ) && $wgUser->isAllowed( 'hideuser' );
 65+ $this->BlockHideName = ( $wgRequest->getBool( 'wpHideName', 0 ) && $wgUser->isAllowed( 'hideuser' ) ) ? 1 : 0;
6666 }
6767
6868 function showForm( $err ) {
Index: branches/liquidthreads/includes/DatabasePostgres.php
@@ -561,7 +561,7 @@
562562 }
563563
564564 function affectedRows() {
565 - if( !isset( $this->mLastResult ) )
 565+ if( !isset( $this->mLastResult ) or ! $this->mLastResult )
566566 return 0;
567567
568568 return pg_affected_rows( $this->mLastResult );
Index: branches/liquidthreads/languages/messages/MessagesEn.php
@@ -1312,7 +1312,7 @@
13131313 'recentchanges-url' => 'Special:Recentchanges',
13141314 'recentchangestext' => 'Track the most recent changes to the wiki on this page.',
13151315 'recentchanges-feed-description' => 'Track the most recent changes to the wiki in this feed.',
1316 -'rcnote' => "Below {{PLURAL:$1|is '''1''' change|are the last '''$1''' changes}} in the last {{PLURAL:$2|day|last '''$2''' days}}, as of $3.",
 1316+'rcnote' => "Below {{PLURAL:$1|is '''1''' change|are the last '''$1''' changes}} in the last {{PLURAL:$2|day|'''$2''' days}}, as of $3.",
13171317 'rcnotefrom' => "Below are the changes since <b>$2</b> (up to <b>$1</b> shown).",
13181318 'rclistfrom' => "Show new changes starting from $1",
13191319 'rcshowhideminor' => '$1 minor edits',
@@ -1958,6 +1958,7 @@
19591959 'istemplate' => 'inclusion',
19601960 'whatlinkshere-prev' => '{{PLURAL:$1|previous|previous $1}}',
19611961 'whatlinkshere-next' => '{{PLURAL:$1|next|next $1}}',
 1962+'whatlinkshere-links' => '(? links)',
19621963
19631964 # Block/unblock IP
19641965 #
Index: branches/liquidthreads/languages/messages/MessagesDe.php
@@ -260,7 +260,7 @@
261261
262262 'about' => 'Über',
263263 'article' => 'Seite',
264 -'newwindow' => '(wird in einem neuen Fenster geöffnet)',
 264+'newwindow' => '(öffnet sich in neuem Fenster)',
265265 'cancel' => 'Abbrechen',
266266 'qbfind' => 'Finden',
267267 'qbbrowse' => 'Blättern',
@@ -540,7 +540,6 @@
541541 # Password reset dialog
542542 'resetpass' => 'Passwort für Benutzerkonto zurücksetzen',
543543 'resetpass_announce' => 'Anmeldung mit dem per E-Mail zugesandten Code. Um die Anmeldung abzuschließen, müssen Sie jetzt ein neues Passwort wählen.',
544 -'resetpass_text' => '<!-- Add text here -->',
545544 'resetpass_header' => 'Passwort zurücksetzen',
546545 'resetpass_submit' => 'Passwort übermitteln und anmelden',
547546 'resetpass_success' => 'Ihr Passwort wurde erfolgreich geändert. Es folgt die Anmeldung …',
@@ -1533,6 +1532,7 @@
15341533 'istemplate' => 'Vorlageneinbindung',
15351534 'whatlinkshere-prev' => '{{PLURAL:$1|vorheriger|vorherige $1}}',
15361535 'whatlinkshere-next' => '{{PLURAL:$1|nächster|nächste $1}}',
 1536+'whatlinkshere-links' => '(← Links)',
15371537
15381538 # Block/unblock
15391539 'blockip' => 'IP-Adresse/Benutzer sperren',
Index: branches/liquidthreads/languages/Names.php
@@ -91,7 +91,7 @@
9292 'gu' => 'ગુજરાતી', # Gujarati
9393 'gv' => 'Gaelg', # Manx
9494 'ha' => 'هَوُسَ', # Hausa
95 - 'hak' => 'Hak-kâ-fâ', # Hakka
 95+ 'hak' => 'Hak-kâ-fa', # Hakka
9696 'haw' => 'Hawai`i', # Hawaiian
9797 'he' => 'עברית', # Hebrew
9898 'hi' => 'हिन्दी', # Hindi
Index: branches/liquidthreads/RELEASE-NOTES
@@ -42,6 +42,7 @@
4343 * (bug 6072) Introducing 'border' keyword to the [[Image:]] syntax
4444 * Introducing 'frameless' keyword to [[Image:]] syntax which respects the
4545 user preferences for image width like 'thumb' but without a frame.
 46+* (bug 7960) Link to "what links here" for each "what links here" entry
4647
4748 == Bugfixes since 1.10 ==
4849
@@ -91,6 +92,7 @@
9293 * (bug 908) Unexistent special pages now generate a red link.
9394 * (bug 7899) Added \hline and \vline to the list of allowed TeX commands
9495 * (bug 7993) support mathematical symbol classes
 96+* (bug 10007) Allow Block IP to work with Postgrs again.
9597
9698 == MediaWiki API changes since 1.10 ==
9799
Property changes on: branches/liquidthreads
___________________________________________________________________
Modified: svnmerge-integrated
98100 - /trunk/phase3:1-22517
99101 + /trunk/phase3:1-22547

Follow-up revisions

RevisionCommit summaryAuthorDate
r22557* (bug 7859) Update Kazakh translations...raymond09:47, 30 May 2007
r22587Merged revisions 22555-22586 via svnmerge from...david03:19, 31 May 2007
r22794* (bug 7859) Update Kazakh translations...raymond10:01, 6 June 2007
r22811Merged revisions 22791-22810 via svnmerge from...david07:26, 7 June 2007
r22901* (bug 7859) Update Kazakh translations...raymond08:53, 11 June 2007
r22919Merged revisions 22878-22918 via svnmerge from...david00:00, 12 June 2007
r22973* (bug 7859) Update Kazakh translations...raymond22:27, 13 June 2007
r23039Merged revisions 22967-23037 via svnmerge from...david20:15, 16 June 2007
r23058* (bug 7859) Update Kazakh translations...raymond07:49, 18 June 2007
r23087Merged revisions 23050-23086 via svnmerge from...david03:14, 19 June 2007
r23201* (bug 7859) Update Kazakh translations...raymond08:40, 22 June 2007
r23203Merged revisions 23120-23202 via svnmerge from...david09:07, 22 June 2007
r23286(bug 7859) Kazakh message updates [patch from AlefZet]robchurch09:27, 23 June 2007
r23407Merged revisions 23203-23405 via svnmerge from...david23:00, 25 June 2007

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r17525(bug 7859) Updates for Kazakh i18nrotem13:30, 10 November 2006
r17537(bug 7859) Updates for Kazakh i18nrotem16:57, 11 November 2006
r17723(bug 7859) Updates for Kazakh i18nrotem13:46, 16 November 2006
r17781(bug 7859) Updates for Kazakh i18nrotem13:03, 18 November 2006
r17908(bug 7859) Updates for Kazakh i18nrotem15:06, 24 November 2006
r17924(bug 7859) Updates for Kazakh i18nrotem14:12, 25 November 2006
r17925(bug 7859) Updates for Kazakh i18nrotem14:35, 25 November 2006
r19547* (bug 7859) yet another kazakh localisation patch.leon09:55, 21 January 2007
r20180* (bug 7859) Update Kazakh messages...raymond18:32, 6 March 2007
r20737* (bug 7859) Update Kazahk translations...raymond12:10, 27 March 2007
r20948* (bug 7859) Update Kazahk translations...raymond18:13, 2 April 2007
r21604* (bug 7859) Update Kazakh translations...raymond04:54, 26 April 2007
r21680* (bug 7859) Update Kazakh translations...raymond05:05, 28 April 2007
r21706* (bug 7859) Update Kazakh translations...raymond20:57, 29 April 2007
r21746* (bug 7859) Update Kazakh translations...raymond09:40, 1 May 2007
r21747* (bug 7859) Update Kazakh translations...raymond09:45, 1 May 2007
r22009* (bug 7859) Update Kazakh translations...raymond20:57, 8 May 2007
r22056* (bug 7859) Update Kazakh translations...raymond21:13, 9 May 2007
r22062* (bug 7859) Update Kazakh translations...raymond10:32, 10 May 2007
r22081* (bug 7859) Update Kazakh translations...raymond19:53, 10 May 2007
r22082* (bug 7859) Update Kazakh translations...raymond20:01, 10 May 2007
r22201* (bug 7859) Update Kazakh translations...raymond10:53, 16 May 2007
r22269* (bug 7859) Update Kazakh translations...raymond20:28, 19 May 2007
r22510* (bug 7859) Update Kazakh translations...raymond16:37, 28 May 2007
r22518Merged revisions 22484-22517 via svnmerge from...david22:22, 28 May 2007
r22535(bug 10041, comment #1) typo in language nameraymond14:11, 29 May 2007
r22536* Adding 1 message to optional per hint (bug 7859, comment# 71)...raymond14:43, 29 May 2007
r22537*Fix fucked up grammar in rcnoteaaron15:29, 29 May 2007
r22541*Add U param to parseinline regexp to fix regression that left the \n in pars...aaron19:53, 29 May 2007
r22543The variable mLastResult may be null /or/ false: check for both in affected r...greg20:28, 29 May 2007
r22544Make sure BlockHideName really defaults to 0, not false. Fixes bug 10007.greg21:04, 29 May 2007
r22546(bug 7960) Link to "what links here" for each "what links here" entry...raymond22:02, 29 May 2007