r104210 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r104209‎ | r104210 | r104211 >
Date:00:20, 25 November 2011
Author:reedy
Status:resolved (Comments)
Tags:
Comment:
"else if" -> "elseif"
Modified paths:
  • /trunk/extensions/CentralNotice/CentralNoticeBannerLogPager.php (modified) (history)
  • /trunk/extensions/CentralNotice/CentralNoticeCampaignLogPager.php (modified) (history)
  • /trunk/extensions/CentralNotice/CentralNoticePageLogPager.php (modified) (history)
  • /trunk/extensions/CollabWatchlist/includes/CollabWatchlistEditor.php (modified) (history)
  • /trunk/extensions/CollabWatchlist/includes/SpecialCollabWatchlist.php (modified) (history)
  • /trunk/extensions/ConfirmEdit/recaptchalib.php (modified) (history)
  • /trunk/extensions/Contest/specials/SpecialContestWelcome.php (modified) (history)
  • /trunk/extensions/Contest/specials/SpecialMyContests.php (modified) (history)
  • /trunk/extensions/ContributionTracking/ContributionTracking.processor.php (modified) (history)
  • /trunk/extensions/DonationInterface/gateway_common/donation.api.php (modified) (history)
  • /trunk/extensions/EmailCapture/SpecialEmailCapture.php (modified) (history)
  • /trunk/extensions/ExtTab/includes/ET_ParserFunctions.php (modified) (history)
  • /trunk/extensions/FCKeditor/FCKeditor.body.php (modified) (history)
  • /trunk/extensions/FCKeditor/FCKeditorParser.body.php (modified) (history)
  • /trunk/extensions/FCKeditor/FCKeditorSajax.body.php (modified) (history)
  • /trunk/extensions/FCKeditor/FCKeditorSkin.body.php (modified) (history)
  • /trunk/extensions/GPoC/SpecialSelection.php (modified) (history)
  • /trunk/extensions/LocalisationUpdate/LocalisationUpdate.class.php (modified) (history)
  • /trunk/extensions/Maps/includes/parserHooks/Maps_MapsDoc.php (modified) (history)
  • /trunk/extensions/MeanEditor/MeanEditorEditPage.body.php (modified) (history)
  • /trunk/extensions/MobileFrontend/library/WURFL/Handlers/AndroidHandler.php (modified) (history)
  • /trunk/extensions/MobileFrontend/library/WURFL/Handlers/Matcher/RISMatcher.php (modified) (history)
  • /trunk/extensions/MogileClient/OBSOLETE (modified) (history)
  • /trunk/extensions/MoodBar/Formatter.php (modified) (history)
  • /trunk/extensions/Nuke/Nuke_body.php (modified) (history)
  • /trunk/extensions/OnlineStatusBar/OnlineStatusBar.body.php (modified) (history)
  • /trunk/extensions/OpenGraphMeta/OpenGraphMeta.php (modified) (history)
  • /trunk/extensions/Oversight/HideRevision.hooks.php (modified) (history)
  • /trunk/extensions/SemanticForms/includes/SF_FormUtils.php (modified) (history)
  • /trunk/extensions/SemanticForms/specials/SF_CreateForm.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/includes/datavalues/SMW_DV_Time.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/includes/parserhooks/SMW_SMWDoc.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/includes/queryprinters/SMW_QP_Aggregatable.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/includes/storage/SMW_SQLHelpers.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/specials/AskSpecial/SMW_SpecialAsk.php (modified) (history)
  • /trunk/extensions/SemanticWebBrowser/specials/SearchTriple/SWB_SpecialBrowseWiki.php (modified) (history)
  • /trunk/extensions/SubPageList/SubPageBase.class.php (modified) (history)
  • /trunk/extensions/Survey/api/ApiQuerySurveys.php (modified) (history)
  • /trunk/extensions/Survey/specials/SpecialTakeSurvey.php (modified) (history)
  • /trunk/extensions/TimedMediaHandler/WebVideoTranscode/WebVideoTranscodeJob.php (modified) (history)
  • /trunk/extensions/Translate/spyc/spyc.php (modified) (history)
  • /trunk/extensions/TwitterLogin/twitteroauth/OAuth.php (modified) (history)
  • /trunk/extensions/UploadWizard/includes/UploadWizardCampaign.php (modified) (history)
  • /trunk/extensions/Validator/includes/parserHooks/Validator_Describe.php (modified) (history)
  • /trunk/extensions/WikiObjectModel/includes/WOM_Processor.php (modified) (history)

Follow-up revisions

RevisionCommit summaryAuthorDate
r104460Partial revert of r104210 - most of the instances of "else if" in this file w...yaron17:34, 28 November 2011
r104647MFT r104065, r104194, r104210, r104243, r104298, r104362, r104485, r104587, r...awjrichards02:16, 30 November 2011
r105276Revert of r104210 - all cases of "else if" in this file were in Javascript, w...yaron05:16, 6 December 2011
r106375MFT r103611, r103620, r103622, r104210, r104368, r106136, r106367awjrichards21:29, 15 December 2011
r107015MFT r103297, r104003, r104210, r104999, r105015, r105740, r105800, r106166, r...awjrichards23:56, 21 December 2011

Comments

#Comment by Nikerabbit (talk | contribs)   04:03, 25 November 2011

Translate/spyc/spyc.php is not maintained in this repo. Those changes will be reverted when new upstream version is loaded.

#Comment by Reedy (talk | contribs)   12:03, 25 November 2011

Bah, I reverted some of the ones in obvious external libraries

I suppose it's not a big deal, and won't break anything either way

Status & tagging log