r105740 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r105739‎ | r105740 | r105741 >
Date:01:08, 10 December 2011
Author:kaldari
Status:ok (Comments)
Tags:
Comment:
adding new larger hide button, and a comment for {{{amount}}}
Modified paths:
  • /trunk/extensions/CentralNotice/CentralNotice.i18n.php (modified) (history)
  • /trunk/extensions/CentralNotice/CentralNotice.php (modified) (history)
  • /trunk/extensions/CentralNotice/centralnotice.js (modified) (history)
  • /trunk/extensions/CentralNotice/special/SpecialBannerLoader.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CentralNotice/special/SpecialBannerLoader.php
@@ -111,6 +111,8 @@
112112
113113 /**
114114 * Extract a message name and send to getMessage() for translation
 115+ * If the field is 'amount', get the current fundraiser donation amount and pass it as a
 116+ * parameter to the message.
115117 * @param $match A message array with 2 members: raw match, short name of message
116118 * @return translated messsage string
117119 * @throws SpecialBannerLoaderException
Index: trunk/extensions/CentralNotice/CentralNotice.php
@@ -86,7 +86,10 @@
8787 'remoteExtPath' => 'CentralNotice',
8888 'scripts' => 'centralnotice.js',
8989 'styles' => 'centralnotice.css',
90 - 'messages' => 'centralnotice-documentwrite-error'
 90+ 'messages' => array(
 91+ 'centralnotice-documentwrite-error',
 92+ 'centralnotice-close-title',
 93+ )
9194 );
9295 $wgResourceModules['ext.centralNotice.bannerStats'] = array(
9396 'localBasePath' => dirname( __FILE__ ),
Index: trunk/extensions/CentralNotice/CentralNotice.i18n.php
@@ -121,6 +121,7 @@
122122 'centralnotice-collapse-button' => 'Collapse link',
123123 'centralnotice-expand-button' => 'Expand link',
124124 'centralnotice-close-button' => 'Close button',
 125+ 'centralnotice-close-title' => 'Close',
125126 'centralnotice-translate-button' => 'Help translate link',
126127 'centralnotice-donate-button' => 'Donate button',
127128 'centralnotice-expanded-banner' => 'Expanded banner',
Index: trunk/extensions/CentralNotice/centralnotice.js
@@ -67,9 +67,13 @@
6868 var bannerField = document.getElementById('templateBody');
6969 switch( buttonType ) {
7070 case 'close': // Insert close button
71 - var buttonValue = '<a href="#" onclick="hideBanner();return false;">'
 71+ var buttonValue = '<a href="#" title="'
 72+ + mw.msg( 'centralnotice-close-title' )
 73+ + '" onclick="hideBanner();return false;">'
7274 + '<img border="0" src="' + mw.config.get( 'stylepath' )
73 - + '/common/images/closewindow.png" alt="Close" /></a>';
 75+ + '/common/images/closewindow19x19.png" alt="'
 76+ + mw.msg( 'centralnotice-close-title' )
 77+ + '" /></a>';
7478 break;
7579 }
7680 if (document.selection) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r105741follow-up to r105740, new larger close buttonkaldari01:10, 10 December 2011
r106903follow-up to r105740, adding the actual graphic to use (in the right branch t...kaldari00:28, 21 December 2011
r107015MFT r103297, r104003, r104210, r104999, r105015, r105740, r105800, r106166, r...awjrichards23:56, 21 December 2011

Comments

#Comment by Kaldari (talk | contribs)   01:11, 10 December 2011

This rev depends on r105741.

#Comment by Kaldari (talk | contribs)   00:30, 21 December 2011

Strike that. This rev depends on r106903. The other rev was in the wrong branch.

Status & tagging log