r106166 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r106165‎ | r106166 | r106167 >
Date:05:17, 14 December 2011
Author:kaldari
Status:ok (Comments)
Tags:
Comment:
fix for bug 32901 - making the log action localizable
Modified paths:
  • /trunk/extensions/CentralNotice/CentralNotice.i18n.php (modified) (history)
  • /trunk/extensions/CentralNotice/CentralNoticeBannerLogPager.php (modified) (history)
  • /trunk/extensions/CentralNotice/CentralNoticeCampaignLogPager.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CentralNotice/CentralNoticeBannerLogPager.php
@@ -64,7 +64,7 @@
6565 wfMsg ( 'centralnotice-user-links', $userLink, $userTalkLink )
6666 );
6767 $htmlOut .= Xml::tags( 'td', array( 'valign' => 'top', 'class' => 'primary' ),
68 - $row->tmplog_action
 68+ wfMsg ( 'centralnotice-action-'.$row->tmplog_action )
6969 );
7070 $htmlOut .= Xml::tags( 'td', array( 'valign' => 'top', 'class' => 'primary' ),
7171 $bannerLink
Index: trunk/extensions/CentralNotice/CentralNotice.i18n.php
@@ -155,6 +155,9 @@
156156 'centralnotice-timestamp' => 'Timestamp',
157157 'centralnotice-user' => 'User',
158158 'centralnotice-action' => 'Action',
 159+ 'centralnotice-action-created' => 'created',
 160+ 'centralnotice-action-modified' => 'modified',
 161+ 'centralnotice-action-removed' => 'removed',
159162 'centralnotice-changed' => 'Changed from <span class="cn-old-value">$1</span> to <span class="cn-new-value">$2</span>',
160163 'centralnotice-on' => 'on',
161164 'centralnotice-off' => 'off',
@@ -283,6 +286,9 @@
284287 'centralnotice-timestamp' => '{{Identical|Timestamp}}',
285288 'centralnotice-user' => '{{Identical|User}}',
286289 'centralnotice-action' => '{{Identical|Action}}',
 290+ 'centralnotice-action-created' => 'Indicates which type of action was performed. Should be lower-case, as if it appeared in the middle of a sentence.',
 291+ 'centralnotice-action-modified' => 'Indicates which type of action was performed. Should be lower-case, as if it appeared in the middle of a sentence.',
 292+ 'centralnotice-action-removed' => 'Indicates which type of action was performed. Should be lower-case, as if it appeared in the middle of a sentence.',
287293 'centralnotice-on' => 'indicates a notice is on air
288294
289295 {{Identical|On}}',
Index: trunk/extensions/CentralNotice/CentralNoticeCampaignLogPager.php
@@ -118,7 +118,7 @@
119119 wfMsg ( 'centralnotice-user-links', $userLink, $userTalkLink )
120120 );
121121 $htmlOut .= Xml::tags( 'td', array( 'valign' => 'top', 'class' => 'primary' ),
122 - $row->notlog_action
 122+ wfMsg ( 'centralnotice-action-'.$row->notlog_action )
123123 );
124124 $htmlOut .= Xml::tags( 'td', array( 'valign' => 'top', 'class' => 'primary' ),
125125 $campaignLink

Follow-up revisions

RevisionCommit summaryAuthorDate
r107015MFT r103297, r104003, r104210, r104999, r105015, r105740, r105800, r106166, r...awjrichards23:56, 21 December 2011

Comments

#Comment by Nikerabbit (talk | contribs)   08:11, 14 December 2011

Middle of what sentence?

Status & tagging log