r104065 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r104064‎ | r104065 | r104066 >
Date:19:16, 23 November 2011
Author:khorn
Status:ok
Tags:
Comment:
GlobalCollect Bank Transfer: Compressing the instruction message by including it in the parent table, and bolding the whole thing, on the results page.
Not exactly "pretty", but less weird-lookin' than it had been.
Modified paths:
  • /trunk/extensions/DonationInterface/globalcollect_gateway/globalcollect_gateway.body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/globalcollect_gateway/globalcollect_gateway.body.php
@@ -260,7 +260,7 @@
261261
262262 $return .= Xml::tags( 'h2', array(), wfMsg( 'donate_interface-bt-information' ) );
263263
264 - $return .= Xml::openElement( 'table', array( 'id' => $id . '_table' ) );
 264+ $return .= Xml::openElement( 'table', array( 'id' => $id . '_table', 'width' => '50%' ) );
265265
266266 foreach ( $fields as $field => $meta ) {
267267
@@ -273,11 +273,13 @@
274274 $return .= Xml::closeElement( 'tr' );
275275 }
276276 }
 277+
 278+ $return .= Xml::openElement( 'tr', array() );
 279+ $return .= Xml::tags( 'td', array('style' => 'font-weight:bold', 'colspan' => '2'), wfMsg( 'donate_interface-bank_transfer_message' ) );
 280+ $return .= Xml::closeElement( 'tr' );
277281
278282 $return .= Xml::closeElement( 'table' ); // close $id . '_table'
279283
280 - $return .= Xml::tags( 'p', array(), wfMsg( 'donate_interface-bank_transfer_message' ) );
281 -
282284 $queryString = '?payment_method=' . $this->adapter->getPaymentMethod() . '&payment_submethod=' . $this->adapter->getPaymentSubmethod();
283285
284286 $url = $this->adapter->getThankYouPage() . $queryString;

Follow-up revisions

RevisionCommit summaryAuthorDate
r104647MFT r104065, r104194, r104210, r104243, r104298, r104362, r104485, r104587, r...awjrichards02:16, 30 November 2011

Status & tagging log