r104209 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r104208‎ | r104209 | r104210 >
Date:00:16, 25 November 2011
Author:reedy
Status:ok
Tags:
Comment:
Improve comment from r104047

Also bump MySQL min requirements to 5.0.2 to save an extra conditional

>= 5.0.2 has been around ages..
Modified paths:
  • /trunk/phase3/includes/db/DatabaseMysql.php (modified) (history)
  • /trunk/phase3/includes/installer/MysqlInstaller.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/db/DatabaseMysql.php
@@ -421,7 +421,7 @@
422422 /**
423423 * Returns slave lag.
424424 *
425 - * On MySQL 4.1.9 and later, this will do a SHOW SLAVE STATUS
 425+ * This will do a SHOW SLAVE STATUS
426426 *
427427 * @return int
428428 */
Index: trunk/phase3/includes/installer/MysqlInstaller.php
@@ -32,7 +32,7 @@
3333
3434 public $supportedEngines = array( 'InnoDB', 'MyISAM' );
3535
36 - public $minimumVersion = '5.0.0';
 36+ public $minimumVersion = '5.0.2';
3737
3838 public $webUserPrivs = array(
3939 'DELETE',
@@ -255,11 +255,6 @@
256256 */
257257 $conn = $status->value;
258258
259 - // Check version, need INFORMATION_SCHEMA and CREATE USER
260 - if ( version_compare( $conn->getServerVersion(), '5.0.2', '<' ) ) {
261 - return false;
262 - }
263 -
264259 // Get current account name
265260 $currentName = $conn->selectField( '', 'CURRENT_USER()', '', __METHOD__ );
266261 $parts = explode( '@', $currentName );
@@ -631,7 +626,7 @@
632627 # MySQL table options to use during installation or update
633628 \$wgDBTableOptions = \"{$tblOpts}\";
634629
635 -# Experimental charset support for MySQL 4.1/5.0.
 630+# Experimental charset support for MySQL 5.0.
636631 \$wgDBmysql5 = {$dbmysql5};";
637632 }
638633 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r104047Kill mysql4 specific code from DatabaseMysql...reedy16:27, 23 November 2011

Status & tagging log