r105015 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r105014‎ | r105015 | r105016 >
Date:22:28, 2 December 2011
Author:kaldari
Status:ok
Tags:
Comment:
more logical setting for geo
Modified paths:
  • /trunk/extensions/CentralNotice/CentralNotice.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CentralNotice/CentralNotice.php
@@ -246,9 +246,7 @@
247247 global $wgNoticeProject;
248248 // Initialize global Javascript variables. We initialize Geo with empty values so if the geo
249249 // IP lookup fails we don't have any surprises.
250 - $geo = (object)array();
251 - $geo->{'city'} = '';
252 - $geo->{'country'} = '';
 250+ $geo = array( 'city' => '', 'country' => '' );
253251 $vars['Geo'] = $geo; // change this to wgGeo as soon as Mark updates on his end
254252 $vars['wgNoticeProject'] = $wgNoticeProject;
255253 return true;

Follow-up revisions

RevisionCommit summaryAuthorDate
r107015MFT r103297, r104003, r104210, r104999, r105015, r105740, r105800, r106166, r...awjrichards23:56, 21 December 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r72948fix groomedBannerList bug, add in more support for geotargetting, remove obso...kaldari00:44, 14 September 2010

Status & tagging log