r104368 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r104367‎ | r104368 | r104369 >
Date:22:55, 27 November 2011
Author:reedy
Status:ok
Tags:
Comment:
Fix wrong method call (getDBname!)

Leave FIXME for undefined variable
Modified paths:
  • /trunk/extensions/ContributionTracking/ContributionTracking.php (modified) (history)
  • /trunk/extensions/ContributionTracking/ContributionTracking.processor.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ContributionTracking/ContributionTracking.processor.php
@@ -331,7 +331,7 @@
332332 if ( $returnTitle ) {
333333 $returnto = wfExpandUrl( $returnTitle->getFullUrl(), PROTO_CURRENT );
334334 } else {
335 - $returnto = $wgContributionTrackingReturnToURLDefault . "/$language";
 335+ $returnto = $wgContributionTrackingReturnToURLDefault . "/$language"; // FIXME: $language is undefined
336336 }
337337 $repost['fields']['return'] = $returnto;
338338 $repost['fields']['currency_code'] = $input['currency_code'];
Index: trunk/extensions/ContributionTracking/ContributionTracking.php
@@ -109,7 +109,7 @@
110110 } else {
111111 global $wgContributionTrackingDBname;
112112
113 - if($updater->getDB()->getDBName() === $wgContributionTrackingDBname) {
 113+ if( $updater->getDB()->getDBname() === $wgContributionTrackingDBname ) {
114114 $updater->addExtensionTable( 'contribution_tracking', $dir . 'ContributionTracking.sql' );
115115 $updater->addExtensionTable( 'contribution_tracking_owa_ref', $dir . 'ContributionTracking_OWA_ref.sql' );
116116 $updater->addExtensionUpdate( array( 'addField', 'contribution_tracking', 'owa_session',

Follow-up revisions

RevisionCommit summaryAuthorDate
r106375MFT r103611, r103620, r103622, r104210, r104368, r106136, r106367awjrichards21:29, 15 December 2011

Status & tagging log