r105800 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r105799‎ | r105800 | r105801 >
Date:15:41, 11 December 2011
Author:reedy
Status:resolved (Comments)
Tags:
Comment:
Whitespace and documentation
Modified paths:
  • /trunk/extensions/CentralNotice/CentralNotice.php (modified) (history)
  • /trunk/extensions/WebFonts/WebFonts.hooks.php (modified) (history)
  • /trunk/extensions/WebFonts/resources/ext.webfonts.css (modified) (history)
  • /trunk/extensions/WikimediaMaintenance/dumpInterwiki.php (modified) (history)

Diff [purge]

Index: trunk/extensions/WebFonts/resources/ext.webfonts.css
@@ -14,12 +14,10 @@
1515 z-index: 99999;
1616 }
1717
18 -
1918 div#webfonts-menu .menu ul {
2019 padding-left: 5px!important;
2120 }
2221
23 -
2422 div#webfonts-fonts li {
2523 margin: 0;
2624 padding: 5px;
Index: trunk/extensions/WebFonts/WebFonts.hooks.php
@@ -11,6 +11,9 @@
1212
1313 /**
1414 * BeforePageDisplay hook handler.
 15+ * @param $out OutputPage
 16+ * @param $skin Skin
 17+ * @return bool
1518 */
1619 public static function addModules( $out, $skin ) {
1720
@@ -23,6 +26,9 @@
2427
2528 /**
2629 * GetPreferences hook handler.
 30+ * @param $user User
 31+ * @param $preferences array
 32+ * @return bool
2733 */
2834 public static function addPreference( $user, &$preferences ) {
2935 // A checkbox in preferences to enable WebFonts
@@ -35,11 +41,13 @@
3642
3743 return true;
3844 }
39 -
 45+
4046 /**
4147 * UserGetDefaultOptions hook handler.
 48+ * @param $defaultOptions array
 49+ * @return bool
4250 */
43 - public static function addDefaultOptions( &$defaultOptions ) {
 51+ public static function addDefaultOptions( &$defaultOptions ) {
4452 global $wgWebFontsEnabledByDefault;
4553 // By default, the preference page option to enable webfonts is set to wgWebFontsEnabledByDefault value.
4654 $defaultOptions['webfontsEnable'] = $wgWebFontsEnabledByDefault;
Index: trunk/extensions/WikimediaMaintenance/dumpInterwiki.php
@@ -56,7 +56,7 @@
5757 $this->dblist = array_map( "trim", file( $this->getOption( 'dblist', "/home/wikipedia/common/all.dblist" ) ) );
5858
5959 # Special-case databases
60 - $this->specials = array_flip( array_map( "trim", file( $this->getOption( 'specialdbs', "/home/wikipedia/common/special.dblist" ) ) ) );
 60+ $this->specials = array_flip( array_map( "trim", file( $this->getOption( 'specialdbs', "/home/wikipedia/common/special.dblist" ) ) ) );
6161
6262 if ( $this->hasOption( 'o' ) ) {
6363 $this->dbFile = CdbWriter::open( $this->getOption( 'o' ) ) ;
@@ -171,7 +171,7 @@
172172 # Special wiki
173173 # Has interwiki links and interlanguage links to wikipedia
174174
175 - $this->makeLink( array( 'iw_prefix' => $db, 'iw_url' => "wiki" ), "__sites" );
 175+ $this->makeLink( array( 'iw_prefix' => $db, 'iw_url' => "wiki", "iw_local" => 1 ), "__sites" );
176176 # Links to multilanguage sites
177177 foreach ( $sites as $targetSite ) {
178178 $this->makeLink( array( 'iw_prefix' => $targetSite->lateral,
@@ -276,7 +276,6 @@
277277 } else {
278278 $this->output( "{$source}:{$entry['iw_prefix']} {$entry['iw_url']} {$entry['iw_local']}\n" );
279279 }
280 -
281280 # Add to list of prefixes
282281 $this->prefixLists[$source][$entry['iw_prefix']] = 1;
283282 }
Index: trunk/extensions/CentralNotice/CentralNotice.php
@@ -159,7 +159,7 @@
160160
161161 $wgSpecialPages['CentralNoticeLogs'] = 'SpecialCentralNoticeLogs';
162162 $wgAutoloadClasses['SpecialCentralNoticeLogs'] = $specialDir . 'SpecialCentralNoticeLogs.php';
163 -
 163+
164164 $wgAutoloadClasses['TemplatePager'] = $dir . 'TemplatePager.php';
165165 $wgAutoloadClasses['CentralNoticePager'] = $dir . 'CentralNoticePager.php';
166166 $wgAutoloadClasses['CentralNoticeCampaignLogPager'] = $dir . 'CentralNoticeCampaignLogPager.php';
@@ -328,7 +328,7 @@
329329 // "username" the user's username
330330 $postData['username'] = $wgUser->getName();
331331
332 - // Security checksum. Prevent users from entering the survey with invalid metrics
 332+ // Security checksum. Prevent users from entering the survey with invalid metrics
333333 $postData['secretkey'] = md5( $salt . serialize( $hashData ) );
334334
335335 // MD5 hash

Follow-up revisions

RevisionCommit summaryAuthorDate
r105847Revert unwanted change from r105800reedy01:41, 12 December 2011
r107015MFT r103297, r104003, r104210, r104999, r105015, r105740, r105800, r106166, r...awjrichards23:56, 21 December 2011

Comments

#Comment by Tim Starling (talk | contribs)   01:31, 12 December 2011
-				$this->makeLink( array( 'iw_prefix' => $db, 'iw_url' => "wiki" ), "__sites" );
+				$this->makeLink( array( 'iw_prefix' => $db, 'iw_url' => "wiki", "iw_local" => 1 ), "__sites" );

Was this change accidental? It's not in your commit message.

Status & tagging log