r106227 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r106226‎ | r106227 | r106228 >
Date:19:02, 14 December 2011
Author:mah
Status:ok (Comments)
Tags:
Comment:
Fix Bug 33099 - “Log filters” hardcoded without localization on [[Special:CentralNoticeLogs]]

Patch from Mormegil
Modified paths:
  • /trunk/extensions/CentralNotice/special/SpecialCentralNoticeLogs.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CentralNotice/special/SpecialCentralNoticeLogs.php
@@ -90,7 +90,7 @@
9191 '<img src="'.$wgExtensionAssetsPath.'/CentralNotice/collapsed.png" id="cn-collapsed-filter-arrow" style="display:inline-block;position:relative;top:-2px;"/>'.
9292 '<img src="'.$wgExtensionAssetsPath.'/CentralNotice/uncollapsed.png" id="cn-uncollapsed-filter-arrow" style="display:none;position:relative;top:-2px;"/>'.
9393 '</a>';
94 - $htmlOut .= Xml::tags( 'span', array( 'style' => 'margin-left: 0.3em;' ), 'Log filters' );
 94+ $htmlOut .= Xml::tags( 'span', array( 'style' => 'margin-left: 0.3em;' ), wfMsg( 'centralnotice-filters' ) );
9595 $htmlOut .= Xml::openElement( 'div', array( 'id' => 'cn-log-filters', 'style' => 'display:none;' ) );
9696 }
9797

Follow-up revisions

RevisionCommit summaryAuthorDate
r107015MFT r103297, r104003, r104210, r104999, r105015, r105740, r105800, r106166, r...awjrichards23:56, 21 December 2011

Comments

#Comment by Nikerabbit (talk | contribs)   22:53, 14 December 2011

I'd prefer wfMsgHtml to have escaping too.

Status & tagging log