r99164 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r99163‎ | r99164 | r99165 >
Date:23:01, 6 October 2011
Author:brion
Status:ok
Tags:
Comment:
Followup to r98583; ProofreadPage was inserting a new newline at the start of the footer on every save, but this wasn't visible until r98583 because the previous save's newline got stripped on the next edit.
Moved the newline insertion from after to before the <noinclude>, so it's no longer considered part of the footer and doesn't expand because it hooks up to a place we *do* strip newlines at the end of the body (but is still there to make sure the footer appears on a separate line :)
Modified paths:
  • /trunk/extensions/ProofreadPage/ProofreadPage_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ProofreadPage/ProofreadPage_body.php
@@ -1045,7 +1045,7 @@
10461046 $text = '<noinclude><pagequality level="' . $editpage->quality . '" user="' . $editpage->username . '" />' .
10471047 '<div class="pagetext">' . $editpage->header."\n\n\n</noinclude>" .
10481048 $editpage->textbox1 .
1049 - "<noinclude>\n" . $editpage->footer . '</div></noinclude>';
 1049+ "\n<noinclude>" . $editpage->footer . '</div></noinclude>';
10501050 $editpage->textbox1 = $text;
10511051 } else {
10521052 // replace deprecated template

Follow-up revisions

RevisionCommit summaryAuthorDate
r99979MFT r99164demon22:13, 16 October 2011
r100383REL1_18 MFT r97886, r97899, r97969, r98179, r98497, r98654, r98773, r98801, r...reedy21:36, 20 October 2011
r1011261.18wmf1: MFT r98669, r99164, r99321, r99332, r99632, r99897, r99914, r99952,...catrope12:09, 28 October 2011
r101183Followup r99164: per the bug comments and the attached patch, the newline nee...catrope19:54, 28 October 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r98583* (bug 26028) Preserve initial newlines in ProofreadPage customized edit inte...brion23:34, 30 September 2011

Status & tagging log