r98654 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r98653‎ | r98654 | r98655 >
Date:03:23, 2 October 2011
Author:aaron
Status:ok (Comments)
Tags:
Comment:
Fix some things noticed in http://www.mediawiki.org/wiki/User:Krinkle/Extension_review/FlaggedRevs_%28front-end%29
* Removed JS from review cancel button
* Don't show advertise JS stuff if the revision was already reviewed
Modified paths:
  • /trunk/extensions/FlaggedRevs/presentation/RevisionReviewFormUI.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/presentation/RevisionReviewFormUI.php
@@ -153,7 +153,7 @@
154154 $u, $wgLang->date( $ts, true ), $wgLang->time( $ts, true ) );
155155 $form .= "</span>";
156156 // Page not under review or under review by this user...
157 - } else {
 157+ } elseif ( !$frev ) { // rev not already reviewed
158158 $form .= '<span id="mw-fr-reviewing-status" style="display:none;"></span>'; // JS widget
159159 }
160160 $form .= "</p>\n";
@@ -198,9 +198,7 @@
199199 # Add the submit buttons
200200 $form .= self::submitButtons( $rejectId, $frev, (bool)$disabled, $reviewIncludes );
201201 # Add "cancel" link
202 - $form .= Linker::link( $article->getTitle(),
203 - wfMsg( 'revreview-cancel' ),
204 - array( 'onClick' => 'history.back(); return history.length <= 1;' ) );
 202+ $form .= Linker::link( $article->getTitle(), wfMsg( 'revreview-cancel' ) );
205203
206204 # Show stability log if there is anything interesting...
207205 if ( $article->isPageLocked() ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r98807MFT r97886,r97892,r97899,r97969,r98179,r98654: ajax reviewing status code cha...aaron20:55, 3 October 2011
r100383REL1_18 MFT r97886, r97899, r97969, r98179, r98497, r98654, r98773, r98801, r...reedy21:36, 20 October 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r97886* Made "under review" notices require the user's consent (bug 31093)...aaron03:38, 23 September 2011

Comments

#Comment by Vigilius (talk | contribs)   03:16, 4 October 2011

should this be tagged 1.18? Has been merged into 1.18wmf

Status & tagging log