r97899 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r97898‎ | r97899 | r97900 >
Date:08:44, 23 September 2011
Author:aaron
Status:ok (Comments)
Tags:todo 
Comment:
FU r97886: fix for JS back button
Modified paths:
  • /trunk/extensions/FlaggedRevs/presentation/RejectConfirmationFormUI.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/presentation/RevisionReviewFormUI.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/presentation/RevisionReviewFormUI.php
@@ -211,7 +211,7 @@
212212 # Add "cancel" link
213213 $form .= Linker::link( $article->getTitle(),
214214 wfMsg( 'revreview-cancel' ),
215 - array( 'onClick' => 'history.back(); return !history.length;' ) );
 215+ array( 'onClick' => 'history.back(); return history.length <= 1;' ) );
216216
217217 # Show stability log if there is anything interesting...
218218 if ( $article->isPageLocked() ) {
Index: trunk/extensions/FlaggedRevs/presentation/RejectConfirmationFormUI.php
@@ -147,7 +147,7 @@
148148 $form .= Html::input( 'wpSubmit', wfMsg( 'revreview-reject-confirm' ), 'submit' );
149149 $form .= ' ';
150150 $form .= $skin->link( $this->form->getPage(), wfMsg( 'revreview-reject-cancel' ),
151 - array( 'onClick' => 'history.back(); return !history.length;' ),
 151+ array( 'onClick' => 'history.back(); return history.length <= 1;' ),
152152 array( 'oldid' => $this->form->getRefId(), 'diff' => $this->form->getOldId() ) );
153153 $form .= Xml::closeElement( 'form' );
154154

Follow-up revisions

RevisionCommit summaryAuthorDate
r98807MFT r97886,r97892,r97899,r97969,r98179,r98654: ajax reviewing status code cha...aaron20:55, 3 October 2011
r100383REL1_18 MFT r97886, r97899, r97969, r98179, r98497, r98654, r98773, r98801, r...reedy21:36, 20 October 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r97886* Made "under review" notices require the user's consent (bug 31093)...aaron03:38, 23 September 2011

Comments

#Comment by Krinkle (talk | contribs)   20:05, 26 September 2011

Since you were going to remove those buttons from PHP, I'll leave this for now with a todo reminder.

Status & tagging log