r101183 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r101182‎ | r101183 | r101184 >
Date:19:54, 28 October 2011
Author:catrope
Status:ok
Tags:
Comment:
Followup r99164: per the bug comments and the attached patch, the newline needs to be removed, not just moved around
Modified paths:
  • /trunk/extensions/ProofreadPage/ProofreadPage_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ProofreadPage/ProofreadPage_body.php
——@@ -1045,7 +1045,7 @@
10461046 $text = '<noinclude><pagequality level="' . $editpage->quality . '" user="' . $editpage->username . '" />' .
10471047 '<div class="pagetext">' . $editpage->header."\n\n\n</noinclude>" .
10481048 $editpage->textbox1 .
1049 - "\n<noinclude>" . $editpage->footer . '</div></noinclude>';
 1049+ "<noinclude>" . $editpage->footer . '</div></noinclude>';
10501050 $editpage->textbox1 = $text;
10511051 } else {
10521052 // replace deprecated template

Follow-up revisions

RevisionCommit summaryAuthorDate
r1011841.18wmf1: MFT r101183catrope19:55, 28 October 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r99164Followup to r98583; ProofreadPage was inserting a new newline at the start of...brion23:01, 6 October 2011

Status & tagging log