r99897 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r99896‎ | r99897 | r99898 >
Date:17:59, 15 October 2011
Author:happy-melon
Status:ok (Comments)
Tags:
Comment:
(bug 31361) broken messages on Special:GlobalBlock.
Modified paths:
  • /trunk/extensions/GlobalBlocking/GlobalBlocking.i18n.php (modified) (history)
  • /trunk/extensions/GlobalBlocking/SpecialGlobalBlock.php (modified) (history)
  • /trunk/phase3/includes/db/Database.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/db/Database.php
@@ -47,7 +47,7 @@
4848 * Fields can be retrieved with $row->fieldname, with fields acting like
4949 * member variables.
5050 *
51 - * @param $res SQL result object as returned from DatabaseBase::query(), etc.
 51+ * @param $res ResultWrapper|object as returned from DatabaseBase::query(), etc.
5252 * @return Row object
5353 * @throws DBUnexpectedError Thrown if the database returns an error
5454 */
Index: trunk/extensions/GlobalBlocking/GlobalBlocking.i18n.php
@@ -30,6 +30,8 @@
3131 'globalblocking-block-expiry-otherfield' => 'Other time:',
3232 'globalblocking-block-legend' => 'Block an IP address globally',
3333 'globalblocking-block-options' => 'Options:',
 34+ 'globalblocking-ipaddress' => 'IP address:',
 35+ 'globalblocking-ipbanononly' => 'Block anonymous users only',
3436 'globalblocking-block-errors' => "Your block was unsuccessful, for the following {{PLURAL:$1|reason|reasons}}:",
3537 'globalblocking-block-ipinvalid' => 'The IP address ($1) you entered is invalid.
3638 Please note that you cannot enter a user name!',
Index: trunk/extensions/GlobalBlocking/SpecialGlobalBlock.php
@@ -181,7 +181,7 @@
182182 $fields = array();
183183
184184 // Who to block
185 - $fields['ipaddress'] =
 185+ $fields['globalblocking-ipaddress'] =
186186 Xml::input( 'wpAddress',
187187 45,
188188 $this->mAddress,
@@ -246,7 +246,7 @@
247247 // Block all users, or just anonymous ones
248248 $fields['globalblocking-block-options'] =
249249 Xml::checkLabel(
250 - wfMsg( 'ipbanononly' ),
 250+ wfMsg( 'globalblocking-ipbanononly' ),
251251 'wpAnonOnly',
252252 'mw-globalblock-anon-only',
253253 $this->mAnonOnly

Follow-up revisions

RevisionCommit summaryAuthorDate
r99969Follow-up r99897: message documentation.happy-melon20:08, 16 October 2011
r100537Reverted r99195 quick-fix per r99897aaron09:51, 23 October 2011
r100840REL1_18: MFT r98426, r99371, r99632, r99897, r99910, r99914, r999952reedy18:47, 26 October 2011
r100842REL1_18 MFT r98607, r99897, r100092reedy18:56, 26 October 2011
r1011261.18wmf1: MFT r98669, r99164, r99321, r99332, r99632, r99897, r99914, r99952,...catrope12:09, 28 October 2011

Comments

#Comment by Happy-melon (talk | contribs)   18:01, 15 October 2011

Note that this changes the id of one of the form rows which is based on the message key, but there doesn't seem to be any way to avoid that.

#Comment by Siebrand (talk | contribs)   18:06, 15 October 2011

Please add message documentation for the newly added messages. Thanks.

#Comment by Duplicatebug (talk | contribs)   18:43, 21 October 2011

Please revert r99195, the message is not needed in core.

Status & tagging log