r99321 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r99320‎ | r99321 | r99322 >
Date:19:28, 8 October 2011
Author:hartman
Status:resolved (Comments)
Tags:
Comment:
Check if there is a prexisting tfoot, before creating a new one.

Follow up to r98669, though this was a problem that also could surface without tfoot emulation.
Modified paths:
  • /trunk/phase3/resources/jquery/jquery.tablesorter.js (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/jquery/jquery.tablesorter.js
——@@ -596,7 +596,12 @@
597597 // and put the <tfoot> at the end of the <table>
598598 var $sortbottoms = $table.find( 'tr.sortbottom' );
599599 if ( $sortbottoms.length ) {
600 - $table.append( $( '<tfoot>' ).append( $sortbottoms ) )
 600+ var $tfoot = $table.find( 'tfoot' );
 601+ if( $tfoot ) {
 602+ $tfoot.eq(0).prepend( $sortbottoms );
 603+ } else {
 604+ $table.append( $( '<tfoot>' ).append( $sortbottoms ) )
 605+ }
601606 }
602607
603608 explodeRowspans( $table );

Follow-up revisions

RevisionCommit summaryAuthorDate
r99994Fix broken test by r99321krinkle22:33, 16 October 2011
r1011261.18wmf1: MFT r98669, r99164, r99321, r99332, r99632, r99897, r99914, r99952,...catrope12:09, 28 October 2011
r101202REL1_18 MFT r98669, r99031, r99321, r99994reedy21:14, 28 October 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r98669Add tfoot emulation to tablesorter. Fixes part of the complaints in bug 31060hartman11:58, 2 October 2011

Comments

#Comment by Siebrand (talk | contribs)   01:18, 10 October 2011

Breaks tablesorter tests in all browsers: http://toolserver.org/~krinkle/testswarm/job/398/

#Comment by TheDJ (talk | contribs)   16:32, 22 October 2011

Test fixed by Krinkle.

Status & tagging log