r99163 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r99162‎ | r99163 | r99164 >
Date:22:59, 6 October 2011
Author:aaron
Status:ok
Tags:
Comment:
MFT r99161 "Don't add 'autoblock disabled' flag for IP range blocks"
Modified paths:
  • /branches/wmf/1.18wmf1/includes/specials/SpecialBlock.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/includes/specials/SpecialBlock.php
@@ -810,7 +810,7 @@
811811 * Return a comma-delimited list of "flags" to be passed to the log
812812 * reader for this block, to provide more information in the logs
813813 * @param $data Array from HTMLForm data
814 - * @param $type Block::TYPE_ constant
 814+ * @param $type Block::TYPE_ constant (USER, RANGE, or IP)
815815 * @return array
816816 */
817817 protected static function blockLogFlags( array $data, $type ) {
@@ -827,7 +827,7 @@
828828 }
829829
830830 # Same as anononly, this is not displayed when blocking an IP address
831 - if( !$data['AutoBlock'] && $type != Block::TYPE_IP ){
 831+ if( !$data['AutoBlock'] && $type == Block::TYPE_USER ){
832832 $flags[] = 'noautoblock';
833833 }
834834

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r99161Don't add 'autoblock disabled' flag for IP range blocksaaron22:57, 6 October 2011

Status & tagging log