r99952 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r99951‎ | r99952 | r99953 >
Date:15:08, 16 October 2011
Author:maxsem
Status:ok (Comments)
Tags:
Comment:
Fixed bug in r99914, also reverted accidental tabs->spaces conversion
Modified paths:
  • /trunk/phase3/RELEASE-NOTES-1.18 (modified) (history)
  • /trunk/phase3/includes/api/ApiWatch.php (modified) (history)

Diff [purge]

Index: trunk/phase3/RELEASE-NOTES-1.18
@@ -702,17 +702,17 @@
703703 MediaWiki.org, and is covered under the GNU Free Documentation License (except
704704 for pages that explicitly state that their contents are in the public domain):
705705
706 - http://www.mediawiki.org/wiki/Documentation
 706+ http://www.mediawiki.org/wiki/Documentation
707707
708708 == Mailing list ==
709709
710710 A mailing list is available for MediaWiki user support and discussion:
711711
712 - http://lists.wikimedia.org/mailman/listinfo/mediawiki-l
 712+ http://lists.wikimedia.org/mailman/listinfo/mediawiki-l
713713
714714 A low-traffic announcements-only list is also available:
715715
716 - http://lists.wikimedia.org/mailman/listinfo/mediawiki-announce
 716+ http://lists.wikimedia.org/mailman/listinfo/mediawiki-announce
717717
718718 It's highly recommended that you sign up for one of these lists if you're
719719 going to run a public MediaWiki, so you can be notified of security fixes.
Index: trunk/phase3/includes/api/ApiWatch.php
@@ -49,7 +49,7 @@
5050 $params = $this->extractRequestParams();
5151 $title = Title::newFromText( $params['title'] );
5252
53 - if ( !$title || $titile->getNamespace() < 0 ) {
 53+ if ( !$title || $title->getNamespace() < 0 ) {
5454 $this->dieUsageMsg( array( 'invalidtitle', $params['title'] ) );
5555 }
5656

Follow-up revisions

RevisionCommit summaryAuthorDate
r1011261.18wmf1: MFT r98669, r99164, r99321, r99332, r99632, r99897, r99914, r99952,...catrope12:09, 28 October 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r99914(bug 31674) Can't edit watchlist if it contains special pagesmaxsem21:06, 15 October 2011

Comments

#Comment by Catrope (talk | contribs)   11:20, 28 October 2011

The ApiWatch.php change seems to have magically found its way into 1.18 somehow.

#Comment by 😂 (talk | contribs)   11:26, 28 October 2011

It's magic! *jazzhands*

Status & tagging log