r98960 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r98959‎ | r98960 | r98961 >
Date:00:37, 5 October 2011
Author:reedy
Status:ok (Comments)
Tags:
Comment:
Oct 5 00:32:16 10.0.2.175 apache2[351]: PHP Warning: Missing argument 2 for efCategoryTreeAjaxWrapper() in /usr/local/apache/common-local/php-1.18/extensions/CategoryTree/CategoryTree.php on line 204

Already been fixed in 1.17wmf1 before, and now in 1.18wmf1
Modified paths:
  • /trunk/extensions/CategoryTree/CategoryTree.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CategoryTree/CategoryTree.php
@@ -224,7 +224,7 @@
225225 * namely, only providing the mode name or number.
226226 * This loads CategoryTreeFunctions.php and calls CategoryTree::ajax()
227227 */
228 -function efCategoryTreeAjaxWrapper( $category, $options, $enc = '' ) {
 228+function efCategoryTreeAjaxWrapper( $category, $options = array(), $enc = '' ) {
229229 global $wgCategoryTreeHTTPCache, $wgSquidMaxage, $wgUseSquid;
230230
231231 if ( is_string( $options ) ) {
@@ -362,6 +362,9 @@
363363
364364 /**
365365 * ArticleFromTitle hook, override category page handling
 366+ *
 367+ * @param $title Title
 368+ * @param $article Article
366369 */
367370 function efCategoryTreeArticleFromTitle( $title, &$article ) {
368371 if ( $title->getNamespace() == NS_CATEGORY ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r98961Same as r98960reedy00:38, 5 October 2011
r100383REL1_18 MFT r97886, r97899, r97969, r98179, r98497, r98654, r98773, r98801, r...reedy21:36, 20 October 2011

Comments

#Comment by G.Hagedorn (talk | contribs)   12:46, 5 October 2011

has been applied to 1.18wmf1, perhaps tag for 1.18 as well?

#Comment by Catrope (talk | contribs)   12:51, 5 October 2011

Tagged

Status & tagging log