r98990 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r98989‎ | r98990 | r98991 >
Date:10:16, 5 October 2011
Author:catrope
Status:ok
Tags:
Comment:
(bug 31363) Expand description URLs for thumbnails to canonical form
Modified paths:
  • /trunk/phase3/includes/filerepo/File.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/filerepo/File.php
@@ -735,7 +735,7 @@
736736 // Get the descriptionUrl to embed it as comment into the thumbnail. Bug 19791.
737737 $descriptionUrl = $this->getDescriptionUrl();
738738 if ( $descriptionUrl ) {
739 - $params['descriptionUrl'] = $wgServer . $descriptionUrl;
 739+ $params['descriptionUrl'] = wfExpandUrl( $descriptionUrl, PROTO_CANONICAL );
740740 }
741741
742742 $script = $this->getTransformScript();

Follow-up revisions

RevisionCommit summaryAuthorDate
r100375REL1_18 MFT r98927, r98990, r99081, r99082, r99091, r99102, r99104, r99126reedy21:08, 20 October 2011
r1007591.18wmf1 MFT r93977, r98990, r99349, r100239, r100242reedy22:51, 25 October 2011

Status & tagging log