r100375 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r100374‎ | r100375 | r100376 >
Date:21:08, 20 October 2011
Author:reedy
Status:ok
Tags:
Comment:
Modified paths:
  • /branches/REL1_18/phase3 (modified) (history)
  • /branches/REL1_18/phase3/includes (modified) (history)
  • /branches/REL1_18/phase3/includes/filerepo/File.php (modified) (history)
  • /branches/REL1_18/phase3/includes/specials (modified) (history)
  • /branches/REL1_18/phase3/includes/specials/SpecialBlockList.php (modified) (history)
  • /branches/REL1_18/phase3/includes/specials/SpecialContributions.php (modified) (history)
  • /branches/REL1_18/phase3/includes/specials/SpecialEditWatchlist.php (modified) (history)
  • /branches/REL1_18/phase3/includes/specials/SpecialUndelete.php (modified) (history)
  • /branches/REL1_18/phase3/languages (modified) (history)
  • /branches/REL1_18/phase3/languages/Language.php (modified) (history)
  • /branches/REL1_18/phase3/resources/jquery/jquery.tablesorter.css (modified) (history)
  • /branches/REL1_18/phase3/skins/vector/screen.css (modified) (history)

Diff [purge]

Index: branches/REL1_18/phase3/skins/vector/screen.css
@@ -216,7 +216,9 @@
217217 cursor: pointer;
218218 }
219219 div.vectorMenuFocus {
220 - background-position: -22px 60%;
 220+ /* @embed */
 221+ background-image: url(images/arrow-down-focus-icon.png);
 222+ background-position: 100% 60%;
221223 }
222224 /* @noflip */
223225 body.rtl div.vectorMenu {
Index: branches/REL1_18/phase3/includes/filerepo/File.php
@@ -674,7 +674,7 @@
675675 // Get the descriptionUrl to embed it as comment into the thumbnail. Bug 19791.
676676 $descriptionUrl = $this->getDescriptionUrl();
677677 if ( $descriptionUrl ) {
678 - $params['descriptionUrl'] = $wgServer . $descriptionUrl;
 678+ $params['descriptionUrl'] = wfExpandUrl( $descriptionUrl, PROTO_CANONICAL );
679679 }
680680
681681 $script = $this->getTransformScript();
Property changes on: branches/REL1_18/phase3/includes/filerepo/File.php
___________________________________________________________________
Modified: svn:mergeinfo
682682 Merged /trunk/phase3/includes/filerepo/File.php:r98990,99081-99082
Index: branches/REL1_18/phase3/includes/specials/SpecialUndelete.php
@@ -399,6 +399,10 @@
400400
401401 # Does this page already exist? We'll have to update it...
402402 $article = new Article( $this->title );
 403+ # Load latest data for the current page (bug 31179)
 404+ $article->loadPageData( 'fromdbmaster' );
 405+ $oldcountable = $article->isCountable();
 406+
403407 $options = 'FOR UPDATE'; // lock page
404408 $page = $dbw->selectRow( 'page',
405409 array( 'page_id', 'page_latest' ),
@@ -532,7 +536,6 @@
533537 }
534538
535539 $created = (bool)$newid;
536 - $oldcountable = $article->isCountable();
537540
538541 // Attach the latest revision to the page...
539542 $wasnew = $article->updateIfNewerOn( $dbw, $revision, $previousRevId );
Index: branches/REL1_18/phase3/includes/specials/SpecialBlockList.php
@@ -244,7 +244,7 @@
245245
246246 switch( $name ) {
247247 case 'ipb_timestamp':
248 - $formatted = $wgLang->timeanddate( $value );
 248+ $formatted = $this->getLang()->timeanddate( $value, /* User preference timezome */ true );
249249 break;
250250
251251 case 'ipb_target':
@@ -270,8 +270,8 @@
271271 break;
272272
273273 case 'ipb_expiry':
274 - $formatted = $wgLang->formatExpiry( $value );
275 - if( $wgUser->isAllowed( 'block' ) ){
 274+ $formatted = $this->getLang()->formatExpiry( $value, /* User preference timezome */ true );
 275+ if( $this->getUser()->isAllowed( 'block' ) ){
276276 if( $row->ipb_auto ){
277277 $links[] = $sk->linkKnown(
278278 SpecialPage::getTitleFor( 'Unblock' ),
Index: branches/REL1_18/phase3/includes/specials/SpecialEditWatchlist.php
@@ -459,7 +459,7 @@
460460 * @return HTMLForm
461461 */
462462 protected function getRawForm(){
463 - $titles = implode( array_map( 'htmlspecialchars', $this->getWatchlist() ), "\n" );
 463+ $titles = implode( $this->getWatchlist(), "\n" );
464464 $fields = array(
465465 'Titles' => array(
466466 'type' => 'textarea',
Index: branches/REL1_18/phase3/includes/specials/SpecialContributions.php
@@ -338,7 +338,7 @@
339339 * @return String: HTML fragment
340340 */
341341 protected function getForm() {
342 - global $wgScript, $wgMiserMode;
 342+ global $wgScript;
343343
344344 $this->opts['title'] = $this->getTitle()->getPrefixedText();
345345 if( !isset( $this->opts['target'] ) ) {
@@ -388,12 +388,6 @@
389389
390390 $tagFilter = ChangeTags::buildTagFilterSelector( $this->opts['tagFilter'] );
391391
392 - $fNS = ( $wgMiserMode ) ? '' :
393 - Html::rawElement( 'span', array( 'style' => 'white-space: nowrap' ),
394 - Xml::label( wfMsg( 'namespace' ), 'namespace' ) . ' ' .
395 - Xml::namespaceSelector( $this->opts['namespace'], '' )
396 - );
397 -
398392 $f .= Xml::fieldset( wfMsg( 'sp-contributions-search' ) ) .
399393 Xml::radioLabel( wfMsgExt( 'sp-contributions-newbies', array( 'parsemag' ) ),
400394 'contribs', 'newbie' , 'newbie', $this->opts['contribs'] == 'newbie' ) . '<br />' .
@@ -403,7 +397,10 @@
404398 'size' => '20',
405399 'required' => ''
406400 ) + ( $this->opts['target'] ? array() : array( 'autofocus' ) ) ) . ' '.
407 - $fNS.
 401+ Html::rawElement( 'span', array( 'style' => 'white-space: nowrap' ),
 402+ Xml::label( wfMsg( 'namespace' ), 'namespace' ) . ' ' .
 403+ Xml::namespaceSelector( $this->opts['namespace'], '' )
 404+ ) .
408405 Xml::checkLabel( wfMsg( 'history-show-deleted' ),
409406 'deletedOnly', 'mw-show-deleted-only', $this->opts['deletedOnly'] ) . '<br />' .
410407 Xml::tags( 'p', null, Xml::checkLabel( wfMsg( 'sp-contributions-toponly' ),
@@ -531,8 +528,7 @@
532529 }
533530
534531 function getNamespaceCond() {
535 - global $wgMiserMode;
536 - if( $this->namespace !== '' && !$wgMiserMode ) {
 532+ if( $this->namespace !== '' ) {
537533 return array( 'page_namespace' => (int)$this->namespace );
538534 } else {
539535 return array();
Property changes on: branches/REL1_18/phase3/includes/specials
___________________________________________________________________
Modified: svn:mergeinfo
540536 Merged /trunk/phase3/includes/specials:r98927,98990,99081-99082,99102,99104,99126
Property changes on: branches/REL1_18/phase3/includes
___________________________________________________________________
Modified: svn:mergeinfo
541537 Merged /trunk/phase3/includes:r98927,98990,99081-99082,99102,99104,99126
Index: branches/REL1_18/phase3/languages/Language.php
@@ -3423,7 +3423,7 @@
34243424 : $infinity;
34253425 } else {
34263426 return $format === true
3427 - ? $this->timeanddate( $expiry )
 3427+ ? $this->timeanddate( $expiry, /* User preference timezome */ true )
34283428 : wfTimestamp( $format, $expiry );
34293429 }
34303430 }
Property changes on: branches/REL1_18/phase3/languages
___________________________________________________________________
Modified: svn:mergeinfo
34313431 Merged /trunk/phase3/languages:r99081-99082
Index: branches/REL1_18/phase3/resources/jquery/jquery.tablesorter.css
@@ -1,5 +1,6 @@
22 /* Table Sorting */
33 table.jquery-tablesorter th.headerSort {
 4+ /* @embed */
45 background-image: url(images/sort_both.gif);
56 cursor: pointer;
67 background-repeat: no-repeat;
@@ -7,8 +8,10 @@
89 padding-right: 21px;
910 }
1011 table.jquery-tablesorter th.headerSortUp {
 12+ /* @embed */
1113 background-image: url(images/sort_up.gif);
1214 }
1315 table.jquery-tablesorter th.headerSortDown {
 16+ /* @embed */
1417 background-image: url(images/sort_down.gif);
1518 }
Property changes on: branches/REL1_18/phase3
___________________________________________________________________
Modified: svn:mergeinfo
1619 Merged /trunk/phase3:r98927,98990,99081-99082,99091,99102,99104,99126

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r98927(bug 31179) Fixed problems with undeletion making bad page rows:...aaron21:31, 4 October 2011
r98990(bug 31363) Expand description URLs for thumbnails to canonical formcatrope10:16, 5 October 2011
r99081Follow r86861, replace spaces with tabs. It's my vim's fault!philip09:49, 6 October 2011
r99082Fix a regression from 1.17: Show date/times in user preference timezone....raymond09:52, 6 October 2011
r99091Followup r98676: add @embedcatrope12:51, 6 October 2011
r99102Revert r88025 (put Special:Contributions namespace filter behind $wgMiserMode...catrope13:44, 6 October 2011
r99104Followup r99102: revert r88026 too, otherwise the dropdown is visible but not...catrope13:48, 6 October 2011
r99126* (bug 31435) Fix raw watchlist edit regression from r84718....brion18:08, 6 October 2011

Status & tagging log