r99102 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r99101‎ | r99102 | r99103 >
Date:13:44, 6 October 2011
Author:catrope
Status:ok (Comments)
Tags:
Comment:
Revert r88025 (put Special:Contributions namespace filter behind $wgMiserMode). People on-wiki really hate this, and Domas gave the green light (see https://bugzilla.wikimedia.org/show_bug.cgi?id=31197#c34 )
Modified paths:
  • /trunk/phase3/includes/specials/SpecialContributions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialContributions.php
@@ -337,7 +337,7 @@
338338 * @return String: HTML fragment
339339 */
340340 protected function getForm() {
341 - global $wgScript, $wgMiserMode;
 341+ global $wgScript;
342342
343343 $this->opts['title'] = $this->getTitle()->getPrefixedText();
344344 if( !isset( $this->opts['target'] ) ) {
@@ -387,12 +387,6 @@
388388
389389 $tagFilter = ChangeTags::buildTagFilterSelector( $this->opts['tagFilter'] );
390390
391 - $fNS = ( $wgMiserMode ) ? '' :
392 - Html::rawElement( 'span', array( 'style' => 'white-space: nowrap' ),
393 - Xml::label( wfMsg( 'namespace' ), 'namespace' ) . ' ' .
394 - Xml::namespaceSelector( $this->opts['namespace'], '' )
395 - );
396 -
397391 $f .= Xml::fieldset( wfMsg( 'sp-contributions-search' ) ) .
398392 Xml::radioLabel( wfMsgExt( 'sp-contributions-newbies', array( 'parsemag' ) ),
399393 'contribs', 'newbie' , 'newbie', $this->opts['contribs'] == 'newbie' ) . '<br />' .
@@ -402,7 +396,10 @@
403397 'size' => '20',
404398 'required' => ''
405399 ) + ( $this->opts['target'] ? array() : array( 'autofocus' ) ) ) . ' '.
406 - $fNS.
 400+ Html::rawElement( 'span', array( 'style' => 'white-space: nowrap' ),
 401+ Xml::label( wfMsg( 'namespace' ), 'namespace' ) . ' ' .
 402+ Xml::namespaceSelector( $this->opts['namespace'], '' )
 403+ ) .
407404 Xml::checkLabel( wfMsg( 'history-show-deleted' ),
408405 'deletedOnly', 'mw-show-deleted-only', $this->opts['deletedOnly'] ) . '<br />' .
409406 Xml::tags( 'p', null, Xml::checkLabel( wfMsg( 'sp-contributions-toponly' ),

Follow-up revisions

RevisionCommit summaryAuthorDate
r991031.18wmf1: MFT r99102catrope13:45, 6 October 2011
r99104Followup r99102: revert r88026 too, otherwise the dropdown is visible but not...catrope13:48, 6 October 2011
r100375REL1_18 MFT r98927, r98990, r99081, r99082, r99091, r99102, r99104, r99126reedy21:08, 20 October 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r88025* removed unused messages because of previous revert....freakolowsky23:31, 13 May 2011

Comments

#Comment by G.Hagedorn (talk | contribs)   15:30, 6 October 2011

was added to 1.18wmf1, please consider tagging for 1.18 as well.

Status & tagging log