r100759 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r100758‎ | r100759 | r100760 >
Date:22:51, 25 October 2011
Author:reedy
Status:ok
Tags:
Comment:
Modified paths:
  • /branches/wmf/1.18wmf1 (modified) (history)
  • /branches/wmf/1.18wmf1/includes (modified) (history)
  • /branches/wmf/1.18wmf1/includes/EditPage.php (modified) (history)
  • /branches/wmf/1.18wmf1/includes/Title.php (modified) (history)
  • /branches/wmf/1.18wmf1/includes/api (modified) (history)
  • /branches/wmf/1.18wmf1/includes/api/ApiExpandTemplates.php (modified) (history)
  • /branches/wmf/1.18wmf1/includes/filerepo/File.php (modified) (history)
  • /branches/wmf/1.18wmf1/includes/resourceloader/ResourceLoaderUserGroupsModule.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/includes/filerepo/File.php
@@ -674,7 +674,7 @@
675675 // Get the descriptionUrl to embed it as comment into the thumbnail. Bug 19791.
676676 $descriptionUrl = $this->getDescriptionUrl();
677677 if ( $descriptionUrl ) {
678 - $params['descriptionUrl'] = $wgServer . $descriptionUrl;
 678+ $params['descriptionUrl'] = wfExpandUrl( $descriptionUrl, PROTO_CANONICAL );
679679 }
680680
681681 $script = $this->getTransformScript();
Property changes on: branches/wmf/1.18wmf1/includes/filerepo/File.php
___________________________________________________________________
Modified: svn:mergeinfo
682682 Merged /trunk/phase3/includes/filerepo/File.php:r98990,99349,100239,100242
Property changes on: branches/wmf/1.18wmf1/includes/EditPage.php
___________________________________________________________________
Modified: svn:mergeinfo
683683 Merged /trunk/phase3/includes/EditPage.php:r99349,100239,100242
Index: branches/wmf/1.18wmf1/includes/api/ApiExpandTemplates.php
@@ -90,7 +90,10 @@
9191 'title' => array(
9292 ApiBase::PARAM_DFLT => 'API',
9393 ),
94 - 'text' => null,
 94+ 'text' => array(
 95+ ApiBase::PARAM_TYPE => 'string',
 96+ ApiBase::PARAM_REQUIRED => true,
 97+ ),
9598 'generatexml' => false,
9699 'includecomments' => false,
97100 );
Property changes on: branches/wmf/1.18wmf1/includes/api
___________________________________________________________________
Modified: svn:mergeinfo
98101 Merged /trunk/phase3/includes/api:r93977,98990,99349,100239,100242
Index: branches/wmf/1.18wmf1/includes/resourceloader/ResourceLoaderUserGroupsModule.php
@@ -33,15 +33,14 @@
3434 protected function getPages( ResourceLoaderContext $context ) {
3535 if ( $context->getUser() ) {
3636 $user = User::newFromName( $context->getUser() );
37 - if( $user instanceof User ){
 37+ if ( $user instanceof User ) {
3838 $pages = array();
39 - foreach( $user->getEffectiveGroups() as $group ){
40 - if( in_array( $group, array( '*', 'user' ) ) ){
 39+ foreach( $user->getEffectiveGroups() as $group ) {
 40+ if ( in_array( $group, array( '*', 'user' ) ) ) {
4141 continue;
4242 }
43 - $g = ucfirst( $group );
44 - $pages["MediaWiki:Group-$g.js"] = array( 'type' => 'script' );
45 - $pages["MediaWiki:Group-$g.css"] = array( 'type' => 'style' );
 43+ $pages["MediaWiki:Group-$group.js"] = array( 'type' => 'script' );
 44+ $pages["MediaWiki:Group-$group.css"] = array( 'type' => 'style' );
4645 }
4746 return $pages;
4847 }
Property changes on: branches/wmf/1.18wmf1/includes/Title.php
___________________________________________________________________
Modified: svn:mergeinfo
4948 Merged /trunk/phase3/includes/Title.php:r99349,100239,100242
Property changes on: branches/wmf/1.18wmf1/includes
___________________________________________________________________
Modified: svn:mergeinfo
5049 Merged /trunk/phase3/includes:r93977,98990,99349,100239,100242
Property changes on: branches/wmf/1.18wmf1
___________________________________________________________________
Modified: svn:mergeinfo
5150 Merged /trunk/phase3:r93977,98990,99349,100239,100242

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r93977Followup r93905 per comment on bug 30230...reedy14:55, 5 August 2011
r98990(bug 31363) Expand description URLs for thumbnails to canonical formcatrope10:16, 5 October 2011
r99349FU r99323: spread blocks for edit/move attempts via the API (which uses these...aaron12:30, 9 October 2011
r100239Follow-up r82285: we should not apply case conversion to these names, because...happy-melon17:09, 19 October 2011
r100242* Fixed undefined var $g error...aaron17:30, 19 October 2011

Status & tagging log