r99126 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r99125‎ | r99126 | r99127 >
Date:18:08, 6 October 2011
Author:brion
Status:ok (Comments)
Tags:
Comment:
* (bug 31435) Fix raw watchlist edit regression from r84718.

Removed double-escaping of text going into textarea, introduced when refactoring the watchlist editor in r84718.
Modified paths:
  • /trunk/phase3/includes/specials/SpecialEditWatchlist.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialEditWatchlist.php
@@ -443,7 +443,7 @@
444444 * @return HTMLForm
445445 */
446446 protected function getRawForm(){
447 - $titles = implode( array_map( 'htmlspecialchars', $this->getWatchlist() ), "\n" );
 447+ $titles = implode( $this->getWatchlist(), "\n" );
448448 $fields = array(
449449 'Titles' => array(
450450 'type' => 'textarea',

Follow-up revisions

RevisionCommit summaryAuthorDate
r99982MFT r99126demon22:15, 16 October 2011
r100375REL1_18 MFT r98927, r98990, r99081, r99082, r99091, r99102, r99104, r99126reedy21:08, 20 October 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r84718Move WatchlistEditor.php to /specials since inside it is essentially a comple...happy-melon23:28, 24 March 2011

Comments

#Comment by Brion VIBBER (talk | contribs)   18:09, 6 October 2011

1.18 regression, needs live merge.

Status & tagging log