r99082 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r99081‎ | r99082 | r99083 >
Date:09:52, 6 October 2011
Author:raymond
Status:ok (Comments)
Tags:
Comment:
Fix a regression from 1.17: Show date/times in user preference timezone.
Ping r84258.
Modified paths:
  • /trunk/phase3/includes/specials/SpecialBlockList.php (modified) (history)
  • /trunk/phase3/languages/Language.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialBlockList.php
@@ -246,7 +246,7 @@
247247
248248 switch( $name ) {
249249 case 'ipb_timestamp':
250 - $formatted = $this->getLang()->timeanddate( $value );
 250+ $formatted = $this->getLang()->timeanddate( $value, /* User preference timezome */ true );
251251 break;
252252
253253 case 'ipb_target':
@@ -272,7 +272,7 @@
273273 break;
274274
275275 case 'ipb_expiry':
276 - $formatted = $this->getLang()->formatExpiry( $value );
 276+ $formatted = $this->getLang()->formatExpiry( $value, /* User preference timezome */ true );
277277 if( $this->getUser()->isAllowed( 'block' ) ){
278278 if( $row->ipb_auto ){
279279 $links[] = Linker::linkKnown(
Index: trunk/phase3/languages/Language.php
@@ -3541,7 +3541,7 @@
35423542 : $infinity;
35433543 } else {
35443544 return $format === true
3545 - ? $this->timeanddate( $expiry )
 3545+ ? $this->timeanddate( $expiry, /* User preference timezome */ true )
35463546 : wfTimestamp( $format, $expiry );
35473547 }
35483548 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r990941.18wmf1: MFT r98235, r98411, r98665, r98676, r98678, r98773, r98812, r99082,...catrope13:01, 6 October 2011
r99136Fix stupid typo in r99082. Thanks to Niklas for CRraymond20:19, 6 October 2011
r100375REL1_18 MFT r98927, r98990, r99081, r99082, r99091, r99102, r99104, r99126reedy21:08, 20 October 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r84258More cleanup in Block.php. Push Block::encodeExpiry() and Block::decodeExpir...happy-melon19:15, 18 March 2011

Comments

#Comment by Nikerabbit (talk | contribs)   17:02, 6 October 2011

Timezome?

Status & tagging log