r100242 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r100241‎ | r100242 | r100243 >
Date:17:30, 19 October 2011
Author:aaron
Status:ok
Tags:
Comment:
* Fixed undefined var $g error
* Style cleanups
Modified paths:
  • /trunk/phase3/includes/resourceloader/ResourceLoaderUserGroupsModule.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/resourceloader/ResourceLoaderUserGroupsModule.php
@@ -33,14 +33,14 @@
3434 protected function getPages( ResourceLoaderContext $context ) {
3535 if ( $context->getUser() ) {
3636 $user = User::newFromName( $context->getUser() );
37 - if( $user instanceof User ){
 37+ if ( $user instanceof User ) {
3838 $pages = array();
39 - foreach( $user->getEffectiveGroups() as $group ){
40 - if( in_array( $group, array( '*', 'user' ) ) ){
 39+ foreach( $user->getEffectiveGroups() as $group ) {
 40+ if ( in_array( $group, array( '*', 'user' ) ) ) {
4141 continue;
4242 }
43 - $pages["MediaWiki:Group-$g.js"] = array( 'type' => 'script' );
44 - $pages["MediaWiki:Group-$g.css"] = array( 'type' => 'style' );
 43+ $pages["MediaWiki:Group-$group.js"] = array( 'type' => 'script' );
 44+ $pages["MediaWiki:Group-$group.css"] = array( 'type' => 'style' );
4545 }
4646 return $pages;
4747 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r100750REL1_18 MFT r98997, r99118, r99370, r99700, r100239, r100242, r100347, r10051...reedy21:51, 25 October 2011
r1007591.18wmf1 MFT r93977, r98990, r99349, r100239, r100242reedy22:51, 25 October 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r100239Follow-up r82285: we should not apply case conversion to these names, because...happy-melon17:09, 19 October 2011

Status & tagging log