r93977 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r93976‎ | r93977 | r93978 >
Date:14:55, 5 August 2011
Author:reedy
Status:ok
Tags:
Comment:
Followup r93905 per comment on bug 30230

Make text parameter of ApiExpandTemplates required
Modified paths:
  • /trunk/phase3/includes/api/ApiExpandTemplates.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiExpandTemplates.php
@@ -90,7 +90,10 @@
9191 'title' => array(
9292 ApiBase::PARAM_DFLT => 'API',
9393 ),
94 - 'text' => null,
 94+ 'text' => array(
 95+ ApiBase::PARAM_TYPE => 'string',
 96+ ApiBase::PARAM_REQUIRED => true,
 97+ ),
9598 'generatexml' => false,
9699 'includecomments' => false,
97100 );

Follow-up revisions

RevisionCommit summaryAuthorDate
r100371REL1_18 MFT r93977, r98884, e98963, e98975reedy20:50, 20 October 2011
r1007591.18wmf1 MFT r93977, r98990, r99349, r100239, r100242reedy22:51, 25 October 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r93905* (bug 30230) action=expandtemplates should not silently override invalid tit...reedy20:04, 4 August 2011

Status & tagging log