r103672 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r103671‎ | r103672 | r103673 >
Date:13:48, 19 November 2011
Author:hartman
Status:ok
Tags:
Comment:
Fix an issue with the header of CologneBlue. Introduced in r97657

Fixes bug 32474
Modified paths:
  • /trunk/phase3/skins/CologneBlue.php (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/CologneBlue.php
@@ -32,23 +32,23 @@
3333 if ( 2 == $qb ) { # Right
3434 $rules[] = "/* @noflip */#quickbar { position: absolute; right: 4px; }";
3535 $rules[] = "/* @noflip */#article { margin-left: 4px; margin-right: 148px; }";
36 - $rules[] = "/* @noflip */#topbar, #footer { margin-right: 152px; }";
 36+ $rules[] = "/* @noflip */#footer { margin-right: 152px; }";
3737 } elseif ( 1 == $qb ) {
3838 $rules[] = "/* @noflip */#quickbar { position: absolute; left: 4px; }";
3939 $rules[] = "/* @noflip */#article { margin-left: 148px; margin-right: 4px; }";
40 - $rules[] = "/* @noflip */#topbar, #footer { margin-left: 152px; }";
 40+ $rules[] = "/* @noflip */#footer { margin-left: 152px; }";
4141 } elseif ( 3 == $qb ) { # Floating left
4242 $rules[] = "/* @noflip */#quickbar { position:absolute; left:4px }";
4343 $rules[] = "/* @noflip */#topbar { margin-left: 148px }";
4444 $rules[] = "/* @noflip */#article { margin-left:148px; margin-right: 4px; }";
4545 $rules[] = "/* @noflip */body>#quickbar { position:fixed; left:4px; top:4px; overflow:auto; bottom:4px;}"; # Hides from IE
46 - $rules[] = "/* @noflip */#topbar, #footer { margin-left: 152px; }";
 46+ $rules[] = "/* @noflip */#footer { margin-left: 152px; }";
4747 } elseif ( 4 == $qb ) { # Floating right
4848 $rules[] = "/* @noflip */#quickbar { position: fixed; right: 4px; }";
4949 $rules[] = "/* @noflip */#topbar { margin-right: 148px }";
5050 $rules[] = "/* @noflip */#article { margin-right: 148px; margin-left: 4px; }";
5151 $rules[] = "/* @noflip */body>#quickbar { position: fixed; right: 4px; top: 4px; overflow: auto; bottom:4px;}"; # Hides from IE
52 - $rules[] = "/* @noflip */#topbar, #footer { margin-left: 152px; }";
 52+ $rules[] = "/* @noflip */#footer { margin-right: 152px; }";
5353 }
5454 $style = implode( "\n", $rules );
5555 $out->addInlineStyle( $style, 'flip' );

Sign-offs

UserFlagDate
Jodotested00:38, 12 January 2012 (struck 00:39, 12 January 2012)

Follow-up revisions

RevisionCommit summaryAuthorDate
r104179REL1_18 MFT r103328, r103634, r103672, r103677, r104033reedy16:27, 24 November 2011
r107953MFT r100348, r101656, r103450, r103672, r103677, r103679, r103694reedy22:32, 3 January 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r97657Fix support of legacy skins Standard & CologneBlue for user language directio...robin19:47, 20 September 2011

Status & tagging log