r103450 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r103449‎ | r103450 | r103451 >
Date:10:10, 17 November 2011
Author:hashar
Status:ok (Comments)
Tags:
Comment:
skip Media: links in addition to Special: links

That one triggered an exception stack trace when using Media:foo as
a target on Special:WhatLinksHere.

Example:
Special:WhatLinksHere/Media:file.png

That is a rare occurence that "should not happen". I am not sure it is
worth backporting to 1.18 although it impacts live site:

http://en.wikipedia.org/wiki/Special:WhatLinksHere/Media:BSicon_uBS2lf.svg
Modified paths:
  • /trunk/phase3/includes/SkinTemplate.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SkinTemplate.php
——@@ -814,7 +814,7 @@
815815 wfRunHooks( 'SkinTemplatePreventOtherActiveTabs', array( &$this, &$preventActiveTabs ) );
816816
817817 // Checks if page is some kind of content
818 - if( !$title->isSpecialPage() ) {
 818+ if( $title->canExist() ) {
819819 // Gets page objects for the related namespaces
820820 $subjectPage = $title->getSubjectPage();
821821 $talkPage = $title->getTalkPage();

Follow-up revisions

RevisionCommit summaryAuthorDate
r105706MFT to REL1_18...hashar20:31, 9 December 2011
r107953MFT r100348, r101656, r103450, r103672, r103677, r103679, r103694reedy22:32, 3 January 2012

Comments

#Comment by Bawolff (talk | contribs)   05:08, 2 December 2011

tagging 1.18wmf1 due to complaints about this happening in irc.

#Comment by MarkAHershberger (talk | contribs)   18:40, 14 December 2011

See Bug #33060

Status & tagging log