r103328 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r103327‎ | r103328 | r103329 >
Date:15:21, 16 November 2011
Author:maxsem
Status:ok (Comments)
Tags:
Comment:
Follow-up r101449 and friends: no need to consider LC rebuild a database update and especially it shouldn't be listed separately for every DB updater
Modified paths:
  • /trunk/phase3/includes/installer/DatabaseUpdater.php (modified) (history)
  • /trunk/phase3/includes/installer/MysqlUpdater.php (modified) (history)
  • /trunk/phase3/includes/installer/OracleUpdater.php (modified) (history)
  • /trunk/phase3/includes/installer/SqliteUpdater.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/DatabaseUpdater.php
@@ -237,6 +237,7 @@
238238
239239 if( isset( $what['purge'] ) ) {
240240 $this->purgeCache();
 241+ $this->rebuildLocalisationCache();
241242 }
242243 if ( isset( $what['stats'] ) ) {
243244 $this->checkStats();
@@ -652,7 +653,7 @@
653654 /**
654655 * Rebuilds the localisation cache
655656 */
656 - protected function doRebuildLocalisationCache() {
 657+ protected function rebuildLocalisationCache() {
657658 /**
658659 * @var $cl RebuildLocalisationCache
659660 */
Index: trunk/phase3/includes/installer/MysqlUpdater.php
@@ -181,7 +181,6 @@
182182 array( 'modifyField', 'user_properties', 'up_property', 'patch-up_property.sql' ),
183183 array( 'addTable', 'uploadstash', 'patch-uploadstash.sql' ),
184184 array( 'addTable', 'user_former_groups', 'patch-user_former_groups.sql'),
185 - array( 'doRebuildLocalisationCache' ),
186185
187186 // 1.19
188187 array( 'addTable', 'config', 'patch-config.sql' ),
Index: trunk/phase3/includes/installer/OracleUpdater.php
@@ -36,7 +36,6 @@
3737 array( 'addIndex', 'user', 'i02', 'patch-user_email_index.sql' ),
3838 array( 'modifyField', 'user_properties', 'up_property', 'patch-up_property.sql' ),
3939 array( 'addTable', 'uploadstash', 'patch-uploadstash.sql' ),
40 - array( 'doRebuildLocalisationCache' ),
4140
4241 //1.19
4342 array( 'addTable', 'config', 'patch-config.sql' ),
Index: trunk/phase3/includes/installer/SqliteUpdater.php
@@ -59,7 +59,6 @@
6060 array( 'addIndex', 'user', 'user_email', 'patch-user_email_index.sql' ),
6161 array( 'addTable', 'uploadstash', 'patch-uploadstash.sql' ),
6262 array( 'addTable', 'user_former_groups', 'patch-user_former_groups.sql'),
63 - array( 'doRebuildLocalisationCache' ),
6463
6564 // 1.19
6665 array( 'addTable', 'config', 'patch-config.sql' ),

Follow-up revisions

RevisionCommit summaryAuthorDate
r103634Don't force a localization cache rebuild if it will be handled automatically.gicode02:53, 19 November 2011
r104179REL1_18 MFT r103328, r103634, r103672, r103677, r104033reedy16:27, 24 November 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r101449Bug 30934 - Warning: Invalid argument supplied for foreach() in /languages/La...reedy05:23, 1 November 2011

Comments

#Comment by Hashar (talk | contribs)   16:23, 24 November 2011

1.18 needs follow up r103634

Status & tagging log