r103671 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r103670‎ | r103671 | r103672 >
Date:13:39, 19 November 2011
Author:reedy
Status:ok
Tags:
Comment:
Modified paths:
  • /branches/wmf/1.18wmf1/extensions (modified) (history)
  • /branches/wmf/1.18wmf1/extensions/CentralAuth/CentralAuthUser.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/extensions/CentralAuth/CentralAuthUser.php
@@ -1512,10 +1512,15 @@
15131513 'attachedMethod' => $row->lu_attached_method,
15141514 );
15151515
 1516+ $localUser = $this->localUserData( $row->lu_wiki );
 1517+
 1518+ if ( $localUser === false ) {
 1519+ continue;
 1520+ }
15161521 // Just for fun, add local user data.
15171522 // Displayed in the steward interface.
15181523 $wikis[$row->lu_wiki] = array_merge( $wikis[$row->lu_wiki],
1519 - $this->localUserData( $row->lu_wiki ) );
 1524+ $localUser );
15201525 }
15211526
15221527 return $wikis;
@@ -1545,6 +1550,9 @@
15461551
15471552 /**
15481553 * Fetch a row of user data needed for migration.
 1554+ *
 1555+ * @param $wikiID String
 1556+ * @return Array|bool
15491557 */
15501558 protected function localUserData( $wikiID ) {
15511559 $lb = wfGetLB( $wikiID );
Property changes on: branches/wmf/1.18wmf1/extensions
___________________________________________________________________
Modified: svn:mergeinfo
15521560 Merged /trunk/extensions:r103669

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r1036694 PHP Warning: array_merge() [<a href='function.array-merge'>function.array-...reedy13:36, 19 November 2011

Status & tagging log