r103679 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r103678‎ | r103679 | r103680 >
Date:14:32, 19 November 2011
Author:hartman
Status:resolved (Comments)
Tags:
Comment:
Fixes broken alignment of catlinks in cologneblue and simple skins.

Follow up to r102297
Fixes bug 32460
Modified paths:
  • /trunk/phase3/skins/cologneblue/screen.css (modified) (history)
  • /trunk/phase3/skins/simple/main.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/simple/main.css
@@ -354,6 +354,13 @@
355355 li.new {
356356 text-decoration: line-through;
357357 }
 358+/**
 359++ * Overrides text justification (user preference)
 360++ * See bug 31990
 361++ */
 362+#catlinks {
 363+ text-align: center;
 364+}
358365 .catlinks {
359366 text-align: center;
360367 width: 80%;
Index: trunk/phase3/skins/cologneblue/screen.css
@@ -103,10 +103,16 @@
104104 td.top-linkcollection {
105105 text-align: right;
106106 }
 107+/**
 108+ * Overrides text justification (user preference)
 109+ * See bug 31990
 110+ */
 111+td.top-linkcollection #catlinks {
 112+ text-align: right;
 113+}
107114 td.top-subheader {
108115 vertical-align: top;
109116 }
110 -
111117 td.bottom {
112118 font-family: Verdana, Arial, sans-serif;
113119 font-size: 10pt;

Follow-up revisions

RevisionCommit summaryAuthorDate
r103747MFT to REL1_18 r103679...hashar11:00, 20 November 2011
r104146fix comment prefixed by '+' introduced in r103679hashar09:46, 24 November 2011
r104147MFT to REL1_18 r104146...hashar09:49, 24 November 2011
r107953MFT r100348, r101656, r103450, r103672, r103677, r103679, r103694reedy22:32, 3 January 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r102297bug 31990 justify paragraphs pref adds extra space to category listing...hashar16:46, 7 November 2011

Comments

#Comment by Hashar (talk | contribs)   11:02, 20 November 2011

Oh I broke the old skin. Sorry about that. Your fix got merged in REL1_18 with r103747.

thanks for your patch!

#Comment by Nikerabbit (talk | contribs)   09:00, 21 November 2011

What's up with those extra +?

#Comment by Hashar (talk | contribs)   09:46, 21 November 2011

Which + are you talking about?

#Comment by P858snake (talk | contribs)   09:48, 21 November 2011
+/**
++ * Overrides text justification (user preference)
++ * See [https://bugzilla.wikimedia.org/show_bug.cgi?id=31990 bug 31990]
++ */
#Comment by Hashar (talk | contribs)   09:50, 24 November 2011

+ prefixing the comment block have been removed with r104146 and the fix was merged in REL1_18 by r104147.

Status & tagging log