r107953 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r107952‎ | r107953 | r107954 >
Date:22:32, 3 January 2012
Author:reedy
Status:ok
Tags:
Comment:
Modified paths:
  • /branches/wmf/1.18wmf1 (modified) (history)
  • /branches/wmf/1.18wmf1/RELEASE-NOTES-1.18 (modified) (history)
  • /branches/wmf/1.18wmf1/includes (modified) (history)
  • /branches/wmf/1.18wmf1/includes/SkinTemplate.php (modified) (history)
  • /branches/wmf/1.18wmf1/includes/Wiki.php (modified) (history)
  • /branches/wmf/1.18wmf1/includes/specials (modified) (history)
  • /branches/wmf/1.18wmf1/includes/specials/SpecialLinkSearch.php (modified) (history)
  • /branches/wmf/1.18wmf1/includes/specials/SpecialSearch.php (modified) (history)
  • /branches/wmf/1.18wmf1/resources/Resources.php (modified) (history)
  • /branches/wmf/1.18wmf1/skins/CologneBlue.php (modified) (history)
  • /branches/wmf/1.18wmf1/skins/cologneblue/screen.css (modified) (history)
  • /branches/wmf/1.18wmf1/skins/common/mwsuggest.js (modified) (history)
  • /branches/wmf/1.18wmf1/skins/simple/main.css (modified) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/skins/CologneBlue.php
@@ -29,23 +29,23 @@
3030 if ( 2 == $qb ) { # Right
3131 $rules[] = "/* @noflip */#quickbar { position: absolute; right: 4px; }";
3232 $rules[] = "/* @noflip */#article { margin-left: 4px; margin-right: 148px; }";
33 - $rules[] = "/* @noflip */#topbar, #footer { margin-right: 152px; }";
 33+ $rules[] = "/* @noflip */#footer { margin-right: 152px; }";
3434 } elseif ( 1 == $qb ) {
3535 $rules[] = "/* @noflip */#quickbar { position: absolute; left: 4px; }";
3636 $rules[] = "/* @noflip */#article { margin-left: 148px; margin-right: 4px; }";
37 - $rules[] = "/* @noflip */#topbar, #footer { margin-left: 152px; }";
 37+ $rules[] = "/* @noflip */#footer { margin-left: 152px; }";
3838 } elseif ( 3 == $qb ) { # Floating left
3939 $rules[] = "/* @noflip */#quickbar { position:absolute; left:4px }";
4040 $rules[] = "/* @noflip */#topbar { margin-left: 148px }";
4141 $rules[] = "/* @noflip */#article { margin-left:148px; margin-right: 4px; }";
4242 $rules[] = "/* @noflip */body>#quickbar { position:fixed; left:4px; top:4px; overflow:auto; bottom:4px;}"; # Hides from IE
43 - $rules[] = "/* @noflip */#topbar, #footer { margin-left: 152px; }";
 43+ $rules[] = "/* @noflip */#footer { margin-left: 152px; }";
4444 } elseif ( 4 == $qb ) { # Floating right
4545 $rules[] = "/* @noflip */#quickbar { position: fixed; right: 4px; }";
4646 $rules[] = "/* @noflip */#topbar { margin-right: 148px }";
4747 $rules[] = "/* @noflip */#article { margin-right: 148px; margin-left: 4px; }";
4848 $rules[] = "/* @noflip */body>#quickbar { position: fixed; right: 4px; top: 4px; overflow: auto; bottom:4px;}"; # Hides from IE
49 - $rules[] = "/* @noflip */#topbar, #footer { margin-left: 152px; }";
 49+ $rules[] = "/* @noflip */#footer { margin-right: 152px; }";
5050 }
5151 $style = implode( "\n", $rules );
5252 $out->addInlineStyle( $style, 'flip' );
@@ -67,7 +67,7 @@
6868
6969 $s .= '</td><td class="top" id="top-syslinks" width="100%">';
7070 $s .= $this->sysLinks();
71 - $s .= '</td></tr><tr><td class="top-linkcollection">';
 71+ $s .= '</td></tr><tr><td class="top-subheader">';
7272
7373 $s .= '<font size="-1"><span id="sitesub">';
7474 $s .= htmlspecialchars( wfMsg( 'sitesubtitle' ) ) . '</span></font>';
Index: branches/wmf/1.18wmf1/skins/common/mwsuggest.js
@@ -50,18 +50,15 @@
5151 window.os_enabled = true;
5252
5353 /**
54 - * <datalist> is a new HTML5 element that allows you to manually supply
55 - * suggestion lists and have them rendered according to the right platform
56 - * conventions. Opera as of version 11 has a fatal problem: the suggestion
57 - * lags behind what the user types by one keypress. (Reported as DSK-276870 to
58 - * Opera's secret bug tracker.) However, Firefox 4 supports it without
59 - * problems, so Opera is just blacklisted here. Ideally we wouldn't blacklist
60 - * future versions, in case they fix it, but the fallback isn't bad at all and
61 - * the failure if they don't fix it is very annoying, so in this case we'll
62 - * blacklist future versions too.
 54+ * <datalist> is a new HTML5 element that allows you to manually
 55+ * supply suggestion lists and have them rendered according to the
 56+ * right platform conventions. Opera as of version 11 has a fatal
 57+ * problem: the suggestion lags behind what the user types by one
 58+ * keypress. (Reported as DSK-276870 to Opera's secret bug tracker.)
 59+ * There are also problems with other browsers, including Firefox and
 60+ * Safari: See bug 31602 for details.
6361 */
64 -window.os_use_datalist = 'list' in document.createElement( 'input' )
65 - && $.client.profile().name != 'opera';
 62+window.os_use_datalist = false;
6663
6764 /** Timeout timer class that will fetch the results */
6865 window.os_Timer = function( id, r, query ) {
Property changes on: branches/wmf/1.18wmf1/skins/common/mwsuggest.js
___________________________________________________________________
Modified: svn:mergeinfo
6966 Merged /trunk/phase3/skins/common/mwsuggest.js:r100348,101656,103450,103672,103677,103679,103694
Index: branches/wmf/1.18wmf1/skins/simple/main.css
@@ -311,6 +311,13 @@
312312 li.new {
313313 text-decoration: line-through;
314314 }
 315+/**
 316++ * Overrides text justification (user preference)
 317++ * See bug 31990
 318++ */
 319+#catlinks {
 320+ text-align: center;
 321+}
315322 .catlinks {
316323 text-align: center;
317324 width: 80%;
Index: branches/wmf/1.18wmf1/skins/cologneblue/screen.css
@@ -103,7 +103,16 @@
104104 td.top-linkcollection {
105105 text-align: right;
106106 }
107 -
 107+/**
 108+ * Overrides text justification (user preference)
 109+ * See bug 31990
 110+ */
 111+td.top-linkcollection #catlinks {
 112+ text-align: right;
 113+}
 114+td.top-subheader {
 115+ vertical-align: top;
 116+}
108117 td.bottom {
109118 font-family: Verdana, Arial, sans-serif;
110119 font-size: 10pt;
Index: branches/wmf/1.18wmf1/RELEASE-NOTES-1.18
@@ -89,8 +89,6 @@
9090 * BREAKING CHANGE: action=watch / action=unwatch now requires a token.
9191 * (bug 8130) Query pages should limit to content namespaces, not just main
9292 namespace.
93 -* Search suggestions (other than in the Vector skin) will now use the HTML5
94 - datalist feature where supported, currently only Firefox 4.
9593 * Special:Contribs now redirects to Special:Contributions.
9694 * (bug 6672) Images are now autorotated according to their EXIF orientation.
9795 This only affects thumbnails; the source remains unrotated.
Property changes on: branches/wmf/1.18wmf1/RELEASE-NOTES-1.18
___________________________________________________________________
Modified: svn:mergeinfo
9896 Merged /trunk/phase3/RELEASE-NOTES-1.18:r100348,101656,103450,103672,103677,103679,103694
Index: branches/wmf/1.18wmf1/includes/Wiki.php
@@ -78,7 +78,12 @@
7979 $ret = Title::newMainPage();
8080 } else {
8181 $ret = Title::newFromURL( $title );
82 - // check variant links so that interwiki links don't have to worry
 82+ // Alias NS_MEDIA page URLs to NS_FILE...we only use NS_MEDIA
 83+ // in wikitext links to tell Parser to make a direct file link
 84+ if ( !is_null( $ret ) && $ret->getNamespace() == NS_MEDIA ) {
 85+ $ret = Title::makeTitle( NS_FILE, $ret->getDBkey() );
 86+ }
 87+ // Check variant links so that interwiki links don't have to worry
8388 // about the possible different language variants
8489 if ( count( $wgContLang->getVariants() ) > 1
8590 && !is_null( $ret ) && $ret->getArticleID() == 0 )
Index: branches/wmf/1.18wmf1/includes/SkinTemplate.php
@@ -853,7 +853,7 @@
854854 wfRunHooks( 'SkinTemplatePreventOtherActiveTabs', array( &$this, &$preventActiveTabs ) );
855855
856856 // Checks if page is some kind of content
857 - if( $title->getNamespace() != NS_SPECIAL ) {
 857+ if( $title->canExist() ) {
858858 // Gets page objects for the related namespaces
859859 $subjectPage = $title->getSubjectPage();
860860 $talkPage = $title->getTalkPage();
Index: branches/wmf/1.18wmf1/includes/specials/SpecialSearch.php
@@ -1020,7 +1020,8 @@
10211021 }
10221022
10231023 protected function shortDialog( $term ) {
1024 - $out = Html::hidden( 'title', $this->getTitle()->getPrefixedText() ) . "\n";
 1024+ $out = Html::hidden( 'title', $this->getTitle()->getPrefixedText() );
 1025+ $out .= Html::hidden( 'profile', $this->profile ) . "\n";
10251026 // Term box
10261027 $out .= Html::input( 'search', $term, 'search', array(
10271028 'id' => $this->profile === 'advanced' ? 'powerSearchText' : 'searchText',
Index: branches/wmf/1.18wmf1/includes/specials/SpecialLinkSearch.php
@@ -55,7 +55,7 @@
5656 $target = $request->getVal( 'target', $par );
5757 $namespace = $request->getIntorNull( 'namespace', null );
5858
59 - $protocols_list[] = '';
 59+ $protocols_list = array();
6060 foreach( $wgUrlProtocols as $prot ) {
6161 $protocols_list[] = $prot;
6262 }
Property changes on: branches/wmf/1.18wmf1/includes/specials
___________________________________________________________________
Modified: svn:mergeinfo
6363 Merged /trunk/phase3/includes/specials:r103694
Property changes on: branches/wmf/1.18wmf1/includes
___________________________________________________________________
Modified: svn:mergeinfo
6464 Merged /trunk/phase3/includes:r101656,103450,103672,103677,103679,103694
Index: branches/wmf/1.18wmf1/resources/Resources.php
@@ -720,7 +720,7 @@
721721 'scripts' => 'common/mwsuggest.js',
722722 'remoteBasePath' => $GLOBALS['wgStylePath'],
723723 'localBasePath' => $GLOBALS['wgStyleDirectory'],
724 - 'dependencies' => array( 'mediawiki.legacy.wikibits', 'jquery.client' ),
 724+ 'dependencies' => 'mediawiki.legacy.wikibits',
725725 'messages' => array( 'search-mwsuggest-enabled', 'search-mwsuggest-disabled' ),
726726 ),
727727 'mediawiki.legacy.preview' => array(
Property changes on: branches/wmf/1.18wmf1
___________________________________________________________________
Modified: svn:mergeinfo
728728 Merged /trunk/phase3:r100348,101656,103450,103672,103677,103679,103694

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r100348Revert r79363, r79364, and r79369 to disable datalists support entirely based...mah14:46, 20 October 2011
r101656Alias NS_MEDIA page views to NS_FILE. Fixes bug 32032.aaron18:47, 2 November 2011
r103450skip Media: links in addition to Special: links...hashar10:10, 17 November 2011
r103672Fix an issue with the header of CologneBlue. Introduced in r97657...hartman13:48, 19 November 2011
r103677Fix the sitesub of cologneblue. Follow up to r80785hartman14:09, 19 November 2011
r103679Fixes broken alignment of catlinks in cologneblue and simple skins....hartman14:32, 19 November 2011
r103694(bug 32228) Special:Search doesn't conserve profile when new search terms are...catrope17:27, 19 November 2011

Status & tagging log