r103694 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r103693‎ | r103694 | r103695 >
Date:17:27, 19 November 2011
Author:catrope
Status:ok (Comments)
Tags:
Comment:
(bug 32228) Special:Search doesn't conserve profile when new search terms are entered
Modified paths:
  • /trunk/phase3/includes/specials/SpecialSearch.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialSearch.php
@@ -1069,7 +1069,8 @@
10701070 * @return string
10711071 */
10721072 protected function shortDialog( $term ) {
1073 - $out = Html::hidden( 'title', $this->getTitle()->getPrefixedText() ) . "\n";
 1073+ $out = Html::hidden( 'title', $this->getTitle()->getPrefixedText() );
 1074+ $out .= Html::hidden( 'profile', $this->profile ) . "\n";
10741075 // Term box
10751076 $out .= Html::input( 'search', $term, 'search', array(
10761077 'id' => $this->profile === 'advanced' ? 'powerSearchText' : 'searchText',

Follow-up revisions

RevisionCommit summaryAuthorDate
r103696MFT in REL1_18 r103694...hashar17:34, 19 November 2011
r107953MFT r100348, r101656, r103450, r103672, r103677, r103679, r103694reedy22:32, 3 January 2012

Comments

#Comment by Catrope (talk | contribs)   17:29, 19 November 2011

Hashar asked for this to be tagged for 1.18 because the profile feature is new in 1.18.

Status & tagging log