r100348 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r100347‎ | r100348 | r100349 >
Date:14:46, 20 October 2011
Author:mah
Status:ok (Comments)
Tags:
Comment:
Revert r79363, r79364, and r79369 to disable datalists support entirely based
on Bug 31602, Bug 31697, Bug 31654, Bug 31658, and even Aryeh Gregor's
comments in
http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2010-December/029593.html
Modified paths:
  • /trunk/phase3/RELEASE-NOTES-1.18 (modified) (history)
  • /trunk/phase3/resources/Resources.php (modified) (history)
  • /trunk/phase3/skins/common/mwsuggest.js (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/common/mwsuggest.js
@@ -50,18 +50,15 @@
5151 window.os_enabled = true;
5252
5353 /**
54 - * <datalist> is a new HTML5 element that allows you to manually supply
55 - * suggestion lists and have them rendered according to the right platform
56 - * conventions. Opera as of version 11 has a fatal problem: the suggestion
57 - * lags behind what the user types by one keypress. (Reported as DSK-276870 to
58 - * Opera's secret bug tracker.) However, Firefox 4 supports it without
59 - * problems, so Opera is just blacklisted here. Ideally we wouldn't blacklist
60 - * future versions, in case they fix it, but the fallback isn't bad at all and
61 - * the failure if they don't fix it is very annoying, so in this case we'll
62 - * blacklist future versions too.
 54+ * <datalist> is a new HTML5 element that allows you to manually
 55+ * supply suggestion lists and have them rendered according to the
 56+ * right platform conventions. Opera as of version 11 has a fatal
 57+ * problem: the suggestion lags behind what the user types by one
 58+ * keypress. (Reported as DSK-276870 to Opera's secret bug tracker.)
 59+ * There are also problems with other browsers, including Firefox and
 60+ * Safari: See bug 31602 for details.
6361 */
64 -window.os_use_datalist = 'list' in document.createElement( 'input' )
65 - && $.client.profile().name != 'opera';
 62+window.os_use_datalist = false;
6663
6764 /** Timeout timer class that will fetch the results */
6865 window.os_Timer = function( id, r, query ) {
Index: trunk/phase3/RELEASE-NOTES-1.18
@@ -95,8 +95,6 @@
9696 create a page or new section.
9797 * (bug 8130) Query pages should limit to content namespaces, not just main
9898 namespace.
99 -* Search suggestions (other than in the Vector skin) will now use the HTML5
100 - datalist feature where supported, currently only Firefox 4.
10199 * Special:Contribs now redirects to Special:Contributions.
102100 * (bug 6672) Images are now autorotated according to their EXIF orientation.
103101 This only affects thumbnails; the source remains unrotated.
Index: trunk/phase3/resources/Resources.php
@@ -719,7 +719,7 @@
720720 'scripts' => 'common/mwsuggest.js',
721721 'remoteBasePath' => $GLOBALS['wgStylePath'],
722722 'localBasePath' => $GLOBALS['wgStyleDirectory'],
723 - 'dependencies' => array( 'mediawiki.legacy.wikibits', 'jquery.client' ),
 723+ 'dependencies' => 'mediawiki.legacy.wikibits',
724724 'messages' => array( 'search-mwsuggest-enabled', 'search-mwsuggest-disabled' ),
725725 ),
726726 'mediawiki.legacy.preview' => array(

Sign-offs

UserFlagDate
Simetricalinspected21:14, 24 October 2011

Follow-up revisions

RevisionCommit summaryAuthorDate
r107907MFT r100348, r100640, r101656, r101867, r101869m r104030reedy17:34, 3 January 2012
r107953MFT r100348, r101656, r103450, r103672, r103677, r103679, r103694reedy22:32, 3 January 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r79363Enable mwsuggest datalist implementation...simetrical19:30, 31 December 2010
r79364Update dependencies for r79363 per Roan's advicesimetrical19:53, 31 December 2010
r79369RELEASE-NOTES update for r79363simetrical20:43, 31 December 2010

Comments

#Comment by MarkAHershberger (talk | contribs)   14:58, 20 October 2011

I meant Bug 31768, not Bug 31658

#Comment by Simetrical (talk | contribs)   21:15, 24 October 2011

Looks reasonable to me. The idea of using the native datalist feature is nice, but I'm unsurprised that it has issues in practice. Having to use div soup instead of native widgets is sad, but that's life.

Status & tagging log