r103634 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r103633‎ | r103634 | r103635 >
Date:02:53, 19 November 2011
Author:gicode
Status:ok (Comments)
Tags:
Comment:
Don't force a localization cache rebuild if it will be handled automatically.
Modified paths:
  • /trunk/phase3/includes/installer/DatabaseUpdater.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/DatabaseUpdater.php
@@ -222,7 +222,7 @@
223223 * @param $what Array: what updates to perform
224224 */
225225 public function doUpdates( $what = array( 'core', 'extensions', 'purge', 'stats' ) ) {
226 - global $wgVersion;
 226+ global $wgLocalisationCacheConf, $wgVersion;
227227
228228 $what = array_flip( $what );
229229 if ( isset( $what['core'] ) ) {
@@ -235,9 +235,12 @@
236236
237237 $this->setAppliedUpdates( $wgVersion, $this->updates );
238238
239 - if( isset( $what['purge'] ) ) {
 239+ if ( isset( $what['purge'] ) ) {
240240 $this->purgeCache();
241 - $this->rebuildLocalisationCache();
 241+
 242+ if ( $wgLocalisationCacheConf['manualRecache'] ) {
 243+ $this->rebuildLocalisationCache();
 244+ }
242245 }
243246 if ( isset( $what['stats'] ) ) {
244247 $this->checkStats();

Follow-up revisions

RevisionCommit summaryAuthorDate
r104179REL1_18 MFT r103328, r103634, r103672, r103677, r104033reedy16:27, 24 November 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r103328Follow-up r101449 and friends: no need to consider LC rebuild a database upda...maxsem15:21, 16 November 2011

Comments

#Comment by Hashar (talk | contribs)   16:17, 24 November 2011

follow up r103328

Status & tagging log