r102440 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r102439‎ | r102440 | r102441 >
Date:20:58, 8 November 2011
Author:platonides
Status:ok (Comments)
Tags:
Comment:
Attempt to fix translatewiki bug 32057
The different Preprocessor::newChild expect false (with strict comparison) if there's no title passed to them.
Modified paths:
  • /trunk/phase3/includes/parser/Parser.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/parser/Parser.php
——@@ -3034,7 +3034,7 @@
30353035 $isLocalObj = false; # $text is a DOM node needing expansion in the current frame
30363036
30373037 # Title object, where $text came from
3038 - $title = null;
 3038+ $title = false;
30393039
30403040 # $part1 is the bit before the first |, and must contain only title characters.
30413041 # Various prefixes will be stripped from it later.

Follow-up revisions

RevisionCommit summaryAuthorDate
r102454Test for bug 32057....platonides21:55, 8 November 2011
r102539REL1_18 MFT r102027, r102414, r102440, r102488reedy17:26, 9 November 2011
r102548MFT r101291 and r102454...platonides17:53, 9 November 2011
r1025981.18wmf1 MFT r101445, r101464, r101666, r101802, r101860, r101990, r102297, r...reedy23:20, 9 November 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r101291Bug 31098: Template loop through MediaWiki: messages (int: function) not bein...platonides22:22, 29 October 2011

Comments

#Comment by Hashar (talk | contribs)   21:41, 8 November 2011

tagging for 1.18* inclusion. Fixed the issue on twn.net

#Comment by RobLa-WMF (talk | contribs)   21:52, 8 November 2011

This was a followup to r101291

Status & tagging log