r102027 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r102026‎ | r102027 | r102028 >
Date:18:47, 4 November 2011
Author:mah
Status:ok (Comments)
Tags:
Comment:
Apply for Bug #31694 -- "During installation, tabbing order (cursor focus) goes to logo instead of 'continue'"
Patch From: Grunny
Modified paths:
  • /trunk/phase3/CREDITS (modified) (history)
  • /trunk/phase3/includes/installer/WebInstallerPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/CREDITS
——@@ -100,6 +100,7 @@
101101 * Erwin Dokter
102102 * FunPika
103103 * Gero Scholz
 104+* Grunny
104105 * Harry Burt
105106 * Ireas
106107 * Jaska Zedlik
Index: trunk/phase3/includes/installer/WebInstallerPage.php
——@@ -223,7 +223,7 @@
224224
225225 $s = $helpHtml;
226226
227 - $s .= Html::openElement( 'select', array( 'id' => $name, 'name' => $name ) ) . "\n";
 227+ $s .= Html::openElement( 'select', array( 'id' => $name, 'name' => $name, 'tabindex' => $this->parent->nextTabIndex() ) ) . "\n";
228228
229229 $languages = Language::getLanguageNames();
230230 ksort( $languages );

Sign-offs

UserFlagDate
Werdnainspected06:52, 6 November 2011

Follow-up revisions

RevisionCommit summaryAuthorDate
r102198re r102027: split up long linesmah21:31, 6 November 2011
r102539REL1_18 MFT r102027, r102414, r102440, r102488reedy17:26, 9 November 2011

Comments

#Comment by Werdna (talk | contribs)   06:52, 6 November 2011

Looks fine, but I think that line needs to be broken. It doesn't fit across my 27" monitor.

#Comment by Nikerabbit (talk | contribs)   10:12, 6 November 2011

Funny that it fits into my 12.1" display :) Or maybe physical display size just has nothing to do with how much text fits in it. Anyway I agree that the line is quite long.

Status & tagging log