r102539 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r102538‎ | r102539 | r102540 >
Date:17:26, 9 November 2011
Author:reedy
Status:ok
Tags:
Comment:
Modified paths:
  • /branches/REL1_18/phase3 (modified) (history)
  • /branches/REL1_18/phase3/CREDITS (modified) (history)
  • /branches/REL1_18/phase3/includes (modified) (history)
  • /branches/REL1_18/phase3/includes/db/DatabaseMysql.php (modified) (history)
  • /branches/REL1_18/phase3/includes/installer/WebInstallerPage.php (modified) (history)
  • /branches/REL1_18/phase3/includes/parser/Parser.php (modified) (history)
  • /branches/REL1_18/phase3/languages (modified) (history)
  • /branches/REL1_18/phase3/languages/Language.php (modified) (history)

Diff [purge]

Index: branches/REL1_18/phase3/includes/db/DatabaseMysql.php
@@ -709,6 +709,7 @@
710710 protected function getDefaultSchemaVars() {
711711 $vars = parent::getDefaultSchemaVars();
712712 $vars['wgDBTableOptions'] = str_replace( 'TYPE', 'ENGINE', $GLOBALS['wgDBTableOptions'] );
 713+ $vars['wgDBTableOptions'] = str_replace( 'CHARSET=mysql4', 'CHARSET=binary', $GLOBALS['wgDBTableOptions'] );
713714 return $vars;
714715 }
715716
Index: branches/REL1_18/phase3/includes/parser/Parser.php
@@ -2942,7 +2942,7 @@
29432943 $isLocalObj = false; # $text is a DOM node needing expansion in the current frame
29442944
29452945 # Title object, where $text came from
2946 - $title = null;
 2946+ $title = false;
29472947
29482948 # $part1 is the bit before the first |, and must contain only title characters.
29492949 # Various prefixes will be stripped from it later.
Index: branches/REL1_18/phase3/includes/installer/WebInstallerPage.php
@@ -219,7 +219,7 @@
220220
221221 $s = $helpHtml;
222222
223 - $s .= Html::openElement( 'select', array( 'id' => $name, 'name' => $name ) ) . "\n";
 223+ $s .= Html::openElement( 'select', array( 'id' => $name, 'name' => $name, 'tabindex' => $this->parent->nextTabIndex() ) ) . "\n";
224224
225225 $languages = Language::getLanguageNames();
226226 ksort( $languages );
Property changes on: branches/REL1_18/phase3/includes
___________________________________________________________________
Modified: svn:mergeinfo
227227 Merged /trunk/phase3/includes:r102027,102414,102440,102488
Index: branches/REL1_18/phase3/languages/Language.php
@@ -433,7 +433,7 @@
434434 }
435435
436436 global $wgExtraGenderNamespaces;
437 - $genders = $wgExtraGenderNamespaces + self::$dataCache->getItem( $this->mCode, 'namespaceGenderAliases' );
 437+ $genders = $wgExtraGenderNamespaces + (array)self::$dataCache->getItem( $this->mCode, 'namespaceGenderAliases' );
438438 foreach ( $genders as $index => $forms ) {
439439 foreach ( $forms as $alias ) {
440440 $aliases[$alias] = $index;
Property changes on: branches/REL1_18/phase3/languages
___________________________________________________________________
Modified: svn:mergeinfo
441441 Merged /trunk/phase3/languages:r102414,102440,102488
Index: branches/REL1_18/phase3/CREDITS
@@ -96,6 +96,7 @@
9797 * Denny Vrandecic
9898 * Erwin Dokter
9999 * FunPika
 100+* Grunny
100101 * Harry Burt
101102 * Ireas
102103 * Jaska Zedlik
Property changes on: branches/REL1_18/phase3
___________________________________________________________________
Modified: svn:mergeinfo
103104 Merged /trunk/phase3:r102027,102414,102440,102488

Follow-up revisions

RevisionCommit summaryAuthorDate
r102548MFT r101291 and r102454...platonides17:53, 9 November 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r102027Apply for Bug #31694 -- "During installation, tabbing order (cursor focus) go...mah18:47, 4 November 2011
r102414Fix fatal introduced in r97296. Seems to happen only after restarting memcached....catrope17:16, 8 November 2011
r102440Attempt to fix translatewiki bug 32057...platonides20:58, 8 November 2011
r102488fix bug #29102: Upgrade fails "Unknown character set: 'mysql4'"...mah03:25, 9 November 2011

Status & tagging log