r102414 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r102413‎ | r102414 | r102415 >
Date:17:16, 8 November 2011
Author:catrope
Status:ok
Tags:
Comment:
Fix fatal introduced in r97296. Seems to happen only after restarting memcached.


( ! ) Fatal error: Unsupported operand types in /srv/org/wikimedia/prototype/wikis/rl2/languages/Language.php on line 479
Call Stack
# Time Memory Function Location
1 0.0002 121976 {main}( ) ../index.php:0
2 0.0082 2959136 MediaWiki->run( ) ../index.php:58
3 0.0082 2959136 MediaWiki->main( ) ../Wiki.php:531
4 0.0082 2959136 MediaWiki->performRequest( ) ../Wiki.php:612
5 0.0165 5012424 MediaWiki->performAction( ) ../Wiki.php:252
6 0.0585 6947008 EditPage->submit( ) ../Wiki.php:506
7 0.0585 6947008 EditPage->edit( ) ../EditPage.php:360
8 0.1441 19979552 EditPage->showEditForm( ) ../EditPage.php:512
9 0.1704 22610032 EditPage->showStandardInputs( ) ../EditPage.php:1574
10 0.1778 22627752 Skin::makeInternalOrExternalUrl( ) ../EditPage.php:2046
11 0.1778 22627752 Skin::makeUrl( ) ../Skin.php:1006
12 0.1779 22627752 Skin::checkTitle( ) ../Skin.php:991
13 0.1780 22627752 Title::newFromText( ) ../Skin.php:1050
14 0.1780 22627752 Title->secureAndSplit( ) ../Title.php:148
15 0.1780 22627752 Language->getNsIndex( ) ../Title.php:2718
16 0.1781 22627752 Language->getNamespaceIds( ) ../Language.php:530
17 0.1782 22627752 Language->getNamespaceAliases( ) ../Language.php:505
Modified paths:
  • /trunk/phase3/languages/Language.php (modified) (history)

Diff [purge]

Index: trunk/phase3/languages/Language.php
@@ -476,7 +476,7 @@
477477 }
478478
479479 global $wgExtraGenderNamespaces;
480 - $genders = $wgExtraGenderNamespaces + self::$dataCache->getItem( $this->mCode, 'namespaceGenderAliases' );
 480+ $genders = $wgExtraGenderNamespaces + (array)self::$dataCache->getItem( $this->mCode, 'namespaceGenderAliases' );
481481 foreach ( $genders as $index => $forms ) {
482482 foreach ( $forms as $alias ) {
483483 $aliases[$alias] = $index;

Follow-up revisions

RevisionCommit summaryAuthorDate
r102539REL1_18 MFT r102027, r102414, r102440, r102488reedy17:26, 9 November 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r97296* (bug 27398) Add $wgExtraGenderNamespaces for configured gendered namespacesnikerabbit16:11, 16 September 2011

Status & tagging log