r102297 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r102296‎ | r102297 | r102298 >
Date:16:46, 7 November 2011
Author:hashar
Status:ok (Comments)
Tags:
Comment:
bug 31990 justify paragraphs pref adds extra space to category listing

When text justification is enabled in user preference, the category list
could show a large space before the first category. Overriding the element
to use left justification is enough to fix the spacing issue albeit the
categories will no more justified.

Thanks to lupo with bug 31990 comments number 8 hinting at the catlinks
element not being properly justified.

This is a regression in REL1_18 and need a backport.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES-1.18 (modified) (history)
  • /trunk/phase3/skins/common/shared.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/common/shared.css
——@@ -272,6 +272,13 @@
273273 /**
274274 * Categories
275275 */
 276+#catlinks {
 277+ /**
 278+ * Overrides text justification (user preference)
 279+ * See bug 31990
 280+ */
 281+ text-align: left;
 282+}
276283 .catlinks ul {
277284 display: inline;
278285 margin: 0;
Index: trunk/phase3/RELEASE-NOTES-1.18
——@@ -491,6 +491,7 @@
492492 * (bug 31822) Error during upgrade due to output buffer reset in stdout
493493 * (bug 31913) Special:MostLinkedTemplates had an incorrect GROUP BY clause
494494 under Microsoft SQL.
 495+* (bug 31990) justify paragraphs pref adds extra space to category listing
495496
496497 === API changes in 1.18 ===
497498 * BREAKING CHANGE: action=watch now requires POST and token.

Sign-offs

UserFlagDate
Nikerabbitinspected08:21, 8 November 2011

Follow-up revisions

RevisionCommit summaryAuthorDate
r102541REL1_18 MFT r102297reedy17:31, 9 November 2011
r1025981.18wmf1 MFT r101445, r101464, r101666, r101802, r101860, r101990, r102297, r...reedy23:20, 9 November 2011
r103679Fixes broken alignment of catlinks in cologneblue and simple skins....hartman14:32, 19 November 2011
r103747MFT to REL1_18 r103679...hashar11:00, 20 November 2011

Comments

#Comment by Hashar (talk | contribs)   17:52, 7 November 2011

Tagging for 1.18 since it is a regression.

Would be nice to have it live too so I am tagging it for 1.18wmf1

#Comment by TheDJ (talk | contribs)   14:25, 19 November 2011

This breaks the category links on cologneblue and simple. See also bug 32460

#Comment by Hashar (talk | contribs)   11:01, 20 November 2011

Oh I broke the old skin. Sorry about that. Your fix got merged with r103747.

Status & tagging log