r102488 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r102487‎ | r102488 | r102489 >
Date:03:25, 9 November 2011
Author:mah
Status:ok
Tags:
Comment:
fix bug #29102: Upgrade fails "Unknown character set: 'mysql4'"

by replacing "mysql4" with "binary"

Trivial enough to be backported, I think.
Modified paths:
  • /trunk/phase3/includes/db/DatabaseMysql.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/db/DatabaseMysql.php
——@@ -799,6 +799,7 @@
800800 protected function getDefaultSchemaVars() {
801801 $vars = parent::getDefaultSchemaVars();
802802 $vars['wgDBTableOptions'] = str_replace( 'TYPE', 'ENGINE', $GLOBALS['wgDBTableOptions'] );
 803+ $vars['wgDBTableOptions'] = str_replace( 'CHARSET=mysql4', 'CHARSET=binary', $GLOBALS['wgDBTableOptions'] );
803804 return $vars;
804805 }
805806

Follow-up revisions

RevisionCommit summaryAuthorDate
r102539REL1_18 MFT r102027, r102414, r102440, r102488reedy17:26, 9 November 2011
r105010Per Timo, the second line would wipe out the firstreedy21:50, 2 December 2011
r108044Fix Bug 29102 - Upgrade fails "Unknown character set: 'mysql4'...mah15:52, 4 January 2012
r108045* (bug 29102) Upgrade fails "Unknown character set: 'mysql4'....reedy16:14, 4 January 2012

Status & tagging log