r102454 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r102453‎ | r102454 | r102455 >
Date:21:55, 8 November 2011
Author:platonides
Status:ok (Comments)
Tags:
Comment:
Test for bug 32057.
Latent bug in quite unused preprocessing path (expansion of heading nodes),
which was exposed by r101291 and fixed in r102440.
This test is used to exercise that code path.
Modified paths:
  • /trunk/phase3/tests/parser/parserTests.txt (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/parser/parserTests.txt
@@ -8891,6 +8891,23 @@
88928892
88938893 !! end
88948894
 8895+!! article
 8896+MediaWiki:Bug32057
 8897+!! text
 8898+== {{int:headline_sample}} ==
 8899+!! endarticle
 8900+
 8901+!! test
 8902+Bug 32057: Title needed when expanding <h> nodes.
 8903+!! options
 8904+title=[[Main Page]]
 8905+!! input
 8906+{{int:Bug32057}}
 8907+!! result
 8908+<h2><span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Main_Page&amp;action=edit&amp;section=1" title="Edit section: Headline text">edit</a>]</span> <span class="mw-headline" id="Headline_text"> Headline text </span></h2>
 8909+
 8910+!! end
 8911+
88958912 TODO:
88968913 more images
88978914 more tables

Follow-up revisions

RevisionCommit summaryAuthorDate
r102548MFT r101291 and r102454...platonides17:53, 9 November 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r101291Bug 31098: Template loop through MediaWiki: messages (int: function) not bein...platonides22:22, 29 October 2011
r102440Attempt to fix translatewiki bug 32057...platonides20:58, 8 November 2011

Comments

#Comment by Hashar (talk | contribs)   22:08, 8 November 2011

Wonderful! Tagging for inclusion in REL1_18 so we get them in jenkins.

Status & tagging log