r102441 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r102440‎ | r102441 | r102442 >
Date:21:06, 8 November 2011
Author:preilly
Status:resolved (Comments)
Tags:
Comment:
fix for bug 31519 - remove bullet points in footer
Modified paths:
  • /trunk/extensions/MobileFrontend/MobileFrontend.php (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/common.css (modified) (history)

Diff [purge]

Index: trunk/extensions/MobileFrontend/stylesheets/common.css
@@ -109,6 +109,14 @@
110110 height: 1.4em;
111111 }
112112
 113+#footer-info ul, li {
 114+ list-style: none;
 115+ list-style-image: none;
 116+ list-style-type: none;
 117+ margin: 0;
 118+ padding: 0;
 119+}
 120+
113121 .divclearable {
114122 border: 1px solid #888;
115123 display: -moz-inline-stack;
Index: trunk/extensions/MobileFrontend/MobileFrontend.php
@@ -310,7 +310,7 @@
311311 $skin = $wgUser->getSkin();
312312 $copyright = $skin->getCopyright();
313313 if ( stristr( $copyright, '<li class="noprint">' ) !== false ) {
314 - $copyright = '<ul><li>' . $copyright . '</li></ul>';
 314+ $copyright = '<ul id="footer-info"><li>' . $copyright . '</li></ul>';
315315 }
316316
317317 // Need to stash the results of the "wfMsg" call before the Output Buffering handler

Follow-up revisions

RevisionCommit summaryAuthorDate
r1024421.18wmf1: MFT r102441preilly21:08, 8 November 2011
r102999fix for ordered listspreilly18:25, 14 November 2011

Comments

#Comment by Yair rand (talk | contribs)   03:50, 14 November 2011

This broke the display of lists inside the content. Ordered lists no longer show numbers, etc.

#Comment by Preilly (talk | contribs)   18:26, 14 November 2011

This should now be fixed in r102999.

Status & tagging log