r101445 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r101444‎ | r101445 | r101446 >
Date:00:17, 1 November 2011
Author:robin
Status:ok (Comments)
Tags:
Comment:
Follow-up r96261: remove the !important again, and then do the script defaults differently (so that those css rules are only for the default and don't affect when the user selected "never" or "always" underline)
Modified paths:
  • /trunk/phase3/includes/resourceloader/ResourceLoaderUserOptionsModule.php (modified) (history)
  • /trunk/phase3/skins/common/shared.css (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/resourceloader/ResourceLoaderUserOptionsModule.php
@@ -97,7 +97,11 @@
9898 // Underline: 2 = browser default, 1 = always, 0 = never
9999 if ( $options['underline'] < 2 ) {
100100 $rules[] = "a { text-decoration: " .
101 - ( $options['underline'] ? 'underline !important' : 'none' ) . "; }";
 101+ ( $options['underline'] ? 'underline' : 'none' ) . "; }";
 102+ } else {
 103+ # The scripts of these languages are very hard to read with underlines
 104+ $rules[] = 'a:lang(ar), a:lang(ckb), a:lang(fa),a:lang(kk-arab), ' .
 105+ 'a:lang(mzn), a:lang(ps), a:lang(ur) { text-decoration: none; }';
102106 }
103107 if ( $options['highlightbroken'] ) {
104108 $rules[] = "a.new, #quickbar a.new { color: #ba0000; }\n";
Index: trunk/phase3/skins/common/shared.css
@@ -52,17 +52,6 @@
5353 direction: rtl;
5454 }
5555
56 -/* The scripts of these languages are very hard to read with underlines */
57 -[lang="ar"] a,
58 -[lang="ckb"] a,
59 -[lang="fa"] a,
60 -[lang="kk-arab"] a,
61 -[lang="mzn"] a,
62 -[lang="ps"] a,
63 -[lang="ur"] a {
64 - text-decoration: none;
65 -}
66 -
6756 /* Default style for semantic tags */
6857 abbr,
6958 acronym,

Follow-up revisions

RevisionCommit summaryAuthorDate
r102533REL1_18: MFT r101314, r101370, r101376, r101417, r101420, r101445, r101464, r...reedy17:04, 9 November 2011
r1025981.18wmf1 MFT r101445, r101464, r101666, r101802, r101860, r101990, r102297, r...reedy23:20, 9 November 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r96261* Mark underline css as !important. It should override other css (such as the...robin21:50, 4 September 2011

Comments

#Comment by Nikerabbit (talk | contribs)   08:42, 8 November 2011

Vector defaults to no underlining, but with chick skin and "browser default" for this option I can see the different for links tagged as fa and fi.

Status & tagging log