r101476 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r101475‎ | r101476 | r101477 >
Date:14:05, 1 November 2011
Author:hashar
Status:ok (Comments)
Tags:
Comment:
bug 32100 installer complains about suhosin GET limit

Our logic was to warn whenever the suhosin GET limit was set.
This patch skip the warning if the limit is 1024 or more.

Also added 'qqq' message for 'config-suhosin-max-value-length'
Modified paths:
  • /trunk/phase3/RELEASE-NOTES-1.18 (modified) (history)
  • /trunk/phase3/includes/installer/Installer.i18n.php (modified) (history)
  • /trunk/phase3/includes/installer/Installer.php (modified) (history)

Diff [purge]

Index: trunk/phase3/RELEASE-NOTES-1.18
@@ -474,6 +474,8 @@
475475 * (bug 30466) Entries in iwlinks table are now cleared when moving a page over
476476 redirect
477477 * (bug 31674) Can't edit watchlist if it contains special pages
 478+* (bug 32100) Installer complains about Suhosin GET limit even if it is
 479+ already set above 1024 bytes
478480
479481 === API changes in 1.18 ===
480482 * BREAKING CHANGE: action=watch now requires POST and token.
Index: trunk/phase3/includes/installer/Installer.php
@@ -981,7 +981,10 @@
982982 protected function envCheckSuhosinMaxValueLength() {
983983 $maxValueLength = ini_get( 'suhosin.get.max_value_length' );
984984 if ( $maxValueLength > 0 ) {
985 - $this->showMessage( 'config-suhosin-max-value-length', $maxValueLength );
 985+ if( $maxValueLength < 1024 ) {
 986+ # Only warn if the value is below the sane 1024
 987+ $this->showMessage( 'config-suhosin-max-value-length', $maxValueLength );
 988+ }
986989 } else {
987990 $maxValueLength = -1;
988991 }
Index: trunk/phase3/includes/installer/Installer.i18n.php
@@ -640,6 +640,7 @@
641641 'config-admin-password' => '{{Identical|Password}}',
642642 'config-admin-email' => '{{Identical|E-mail address}}',
643643 'config-subscribe' => 'Used as label for the installer checkbox',
 644+ 'config-suhosin-max-value-length' => 'Message shown when PHP parameter suhosin.get.max_value_length is between 0 and 1023 (that max value is hard set in MediaWiki software',
644645 'config-profile-help' => 'Messages referenced:
645646 * {{msg-mw|config-profile-wiki}}
646647 * {{msg-mw|config-profile-no-anon}}

Sign-offs

UserFlagDate
Nikerabbitinspected15:03, 1 November 2011

Follow-up revisions

RevisionCommit summaryAuthorDate
r102533REL1_18: MFT r101314, r101370, r101376, r101417, r101420, r101445, r101464, r...reedy17:04, 9 November 2011

Comments

#Comment by Hashar (talk | contribs)   14:08, 1 November 2011

minor bug fix for REL1_18.

Also impact 1.17 but I am not sure we will make a new release for REL1_17.

Status & tagging log